Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params passed in pub/index.php being overwritten #472

Closed
wbyrnetx opened this issue Jan 17, 2014 · 2 comments
Closed

Params passed in pub/index.php being overwritten #472

wbyrnetx opened this issue Jan 17, 2014 · 2 comments

Comments

@wbyrnetx
Copy link
Contributor

It seems like the params (specifically the \Magento\Filesystem::PARAM_APP_DIRS ones) are being overridden when
$directoryListConfig->configure($directories);
is called in lib/Magento/App/ObjectManagerFactory.php [line 148]

Magento\Filesystem\DirectoryList\Configuration pulls directory info from app/code/Magento/Core/etc/config.xml and overrides any params I have set in index.php, should it not be the other way around? Or do params defined in index.php not take precedence over config?

i.e. $params[\Magento\Filesystem::PARAM_APP_DIRS][\Magento\Filesystem::PUB] = array('uri' => '');

@verklov
Copy link
Contributor

verklov commented Jan 24, 2014

@wbyrne , thank you for reporting this issue! We will look at the issue and respond to you once we have a resolution.

magento-team added a commit that referenced this issue Mar 18, 2014
* Themes update:
  * LESS styles library added in pub/lib/css/
  * A new Blank theme set as default
* GitHub requests:
  * [#491](#491) -- Fixed bug, incorrect auto-generation Category URL for some groups of symbols (idish, cirrilic, , , and other).
  * [#480](#480) -- Fixing a bug for loading config from local.xml
  * [#472](#472) -- Params passed in pub/index.php being overwritten
  * [#461](#461) -- Use translates for Quote\Address\Total\Shipping
  * [#235](#235) -- Translation escaping
  * [#463](#463) -- allow _resolveArguments to do sequential lookups
  * [#499](#499) Deleted unclosed comment in calendar.css
* Fixed bugs:
  * Fixed a fatal error that occurred with a dependency in pub/errors/report.php
  * Fixed an issue where code coverage failed for Magento\SalesRule\Model\Rule\Action\Discount\CartFixedTest
  * Fixed an issue where PayPal Express Checkout redirected to the PayPal site even though the Allow Guest Checkout option was set to 'No'
  * Fixed an issue where invalid password reset link was sent when resetting customer password from the backend
  * Fixed an issue where it was not possible to download a previously created backup
  * Fixed a security issue with possibility of a XSS injection in the Integration re-authorization flow
  * Fixed an issue where Billing Agreement cancellation from the backend did not work
  * Fixed an issue with the debug section in the developer settings
  * Fixed the unreliable implementation of the fetching authorization header via SOAP
  * Fixed issues with WSDL generation error reporting
  * Fixed an issue with incorrect order of the Recurring Profile tab in Account Customer on the frontend
  * Fixed an issue when the information about a custom option of the 'File' type was not displayed correctly on the recurring profile page
  * Fixed an issue with editing Product template
  * Fixed an issue with duplicated shipping method options during checkout
  * Fixed an issue where flat indexers were re-indexed in shell when they were disabled
  * Fixed an issue where adding a wrong/nonexistent SKU using 'Order by SKU' from My Account caused a fatal error
  * Fixed an issue with the JS/CSS merging functionality
  * Fixed an issue with static view files publication tool used for the 'production' mode
* Modularity improvements:
  * Removed the deprecated GoogleCheckout functionality
  * Removed all dependencies on the RecurringPayment module
  * Removed the Sales module dependencies on Customer models/blocks
  * Renamed the RecurringProfile module to RecurringPayment
  * Resolved dependencies between the Email Templates functionality and other modules
  * Moved Core module lib-only depended components to library
  * Moved CSS URL resolving logic from publisher to the separate CSS pre-processor
  * Re-factored the View publisher
* Framework improvements:
  * Added restrictions on the data populated to the Service Data Object
  * Renamed Data Transfer Object to Service Data Object
  * Updated the view files population tool to support LESS
* Customer Service usage:
  * Refactored the Tax module to use Customer service layer
  * Refactored Customer module Adminhtml internal controllers and helper to use Customer services
  * Added and updated the Customer service APIs
  * Exposed Customer services as REST APIs
* Indexer implementation:
  * Implemented a new optimized Product Price Indexer
* Updated various PHPDoc with the parameter and return types
@verklov
Copy link
Contributor

verklov commented Mar 19, 2014

@wbyrne, the team has fixed your issue. The fix is available in version dev69.

@verklov verklov closed this as completed Mar 19, 2014
vpelipenko added a commit that referenced this issue Jul 15, 2015
[API] Bug Fixes 39919, 39700
magento-team pushed a commit that referenced this issue Mar 23, 2016
…ic-files-are-not-loaded

[Extensibility] Magetwo 50657 static files are not loaded
magento-engcom-team added a commit that referenced this issue Mar 30, 2019
 - Merge Pull Request magento/graphql-ce#472 from magento/graphql-ce:428-getAvailableShippingMethodsTest
 - Merged commits:
   1. 36a5981
   2. 10a2202
   3. 4ed4d59
   4. 89a8621
   5. d2a7142
   6. c0b8e3d
   7. 99134c0
   8. 8136c38
   9. 0b8bebc
   10. 38dd5a0
   11. 18e41ba
   12. d4c2b89
   13. b64170a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants