Fixing a bug for loading config from local.xml #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic has a problem if the depth of the xml path is more than five, for example, try old cache node in local.xml. Fixed with a key check. By the way, how to add memcache support for magento2?
|
When can release out? |
|
Well, it depends on the magento team. Let's just wait. |
|
I can't wait to see the final version.Magento2 awesome, jquery is too great!! |
|
@realkoyu , thanks for reporting this issue to us! We created a ticket and placed it to the product backlog. Once we resolve it, we will share the update with you. |
magento-team
added a commit
that referenced
this pull request
Mar 18, 2014
* Themes update: * LESS styles library added in pub/lib/css/ * A new Blank theme set as default * GitHub requests: * [#491](#491) -- Fixed bug, incorrect auto-generation Category URL for some groups of symbols (idish, cirrilic, , , and other). * [#480](#480) -- Fixing a bug for loading config from local.xml * [#472](#472) -- Params passed in pub/index.php being overwritten * [#461](#461) -- Use translates for Quote\Address\Total\Shipping * [#235](#235) -- Translation escaping * [#463](#463) -- allow _resolveArguments to do sequential lookups * [#499](#499) Deleted unclosed comment in calendar.css * Fixed bugs: * Fixed a fatal error that occurred with a dependency in pub/errors/report.php * Fixed an issue where code coverage failed for Magento\SalesRule\Model\Rule\Action\Discount\CartFixedTest * Fixed an issue where PayPal Express Checkout redirected to the PayPal site even though the Allow Guest Checkout option was set to 'No' * Fixed an issue where invalid password reset link was sent when resetting customer password from the backend * Fixed an issue where it was not possible to download a previously created backup * Fixed a security issue with possibility of a XSS injection in the Integration re-authorization flow * Fixed an issue where Billing Agreement cancellation from the backend did not work * Fixed an issue with the debug section in the developer settings * Fixed the unreliable implementation of the fetching authorization header via SOAP * Fixed issues with WSDL generation error reporting * Fixed an issue with incorrect order of the Recurring Profile tab in Account Customer on the frontend * Fixed an issue when the information about a custom option of the 'File' type was not displayed correctly on the recurring profile page * Fixed an issue with editing Product template * Fixed an issue with duplicated shipping method options during checkout * Fixed an issue where flat indexers were re-indexed in shell when they were disabled * Fixed an issue where adding a wrong/nonexistent SKU using 'Order by SKU' from My Account caused a fatal error * Fixed an issue with the JS/CSS merging functionality * Fixed an issue with static view files publication tool used for the 'production' mode * Modularity improvements: * Removed the deprecated GoogleCheckout functionality * Removed all dependencies on the RecurringPayment module * Removed the Sales module dependencies on Customer models/blocks * Renamed the RecurringProfile module to RecurringPayment * Resolved dependencies between the Email Templates functionality and other modules * Moved Core module lib-only depended components to library * Moved CSS URL resolving logic from publisher to the separate CSS pre-processor * Re-factored the View publisher * Framework improvements: * Added restrictions on the data populated to the Service Data Object * Renamed Data Transfer Object to Service Data Object * Updated the view files population tool to support LESS * Customer Service usage: * Refactored the Tax module to use Customer service layer * Refactored Customer module Adminhtml internal controllers and helper to use Customer services * Added and updated the Customer service APIs * Exposed Customer services as REST APIs * Indexer implementation: * Implemented a new optimized Product Price Indexer * Updated various PHPDoc with the parameter and return types
|
@realkoyu, the team has processed your pull request. The fix is available in version dev69. |
magento-team
added a commit
that referenced
this pull request
Sep 1, 2014
* Price template refactoring * Refactored order item templates in the Sales, Bundle and Downloadable modules * Eliminated the unused PHTML templates and removed the direct dependencies on the TaxHelper module in the Catalog module * Service layer implementation: * Created service layer for Order creation * Created service layer for Invoice * Created service layer for Credit Memo * Created service layer for Shipment * Introduce the Search library: * Created adapter interfaces for the Search library * Created response structure * Created parsing of XML declaration and creation of library objects (Queries, Filters, Aggregations) * Refactored Framework\Stdlib\Cookie to use CookieManager * Added the ability to prevent the backend cookie from going to the storefront * Fixed bugs: * Fixed an issue where taxes were not added in some orders * Fixed an issue were the Add New Address button did not work if the default address was already set * Fixed a Google Chrome and Internet Explorer specific issue when a JavaScript error made it impossible to register during checkout downloadable product * Fixed an issue when the credit card iframe (PayPal or 3D secure) was absent on the Order Review step during Onepage Checkout * Fixed an issue with the Tax Rate, Customer Tax Class and Product Tax Class multiselects on the Tax Rule Information page * Fixed JavaScript issues which prevented saving a newsletter template. * Modified the Button component behavior * Fixed an issue where it was impossible for a guest customer to register during Onepage checkout when the Require Customer To Be Logged In To Checkout option was set to Yes * Fixed an issue where the Calendar icons were not displayed on the storefront * Fixed an AJAX loader issue in the Admin panel * Fixed an issue where it was impossible to upload images for variations of a configurable product on product form * Fixed an issue where clicking on a row in the Search Terms Report Grid leads to 404 page * Fixed an issue where configurable products fixture creates out of stock products * Fixed an issue where Magento crashed when invalid cookie domain was set * Fixed an issue where the Change checkbox label overlapped the text message for a recurring profile attribute on the attribute mass update page * Fixed an issue where integrity test determined normal dependencies as redundant * Fixed an issue where Catalog\Service\V1\Product\Attribute\ReadService::search returned an error * Fixed an issue where Magento\Catalog\Service\V1\Category\Attribute\ReadService::options returned empty results * GitHub requests: * [#160] (https://github.com/magento/bugathon_march_2013/issues/160) -- Wrong default value for memory_limit in .htaccess.sample * [#480] (#480) -- Provide instructions on adding memcache support for Magento 2 * [#612] (#612) -- Category Layered Navigation : Selection of disabled entity * [#626] (#626) -- Unable to install under IIS / FastCGI
magento-team
pushed a commit
that referenced
this pull request
Jul 17, 2015
[Dragons] New interface and Obsolete connection test
okorshenko
pushed a commit
that referenced
this pull request
Dec 14, 2016
Fixed issues: - MAGETWO-59102 Bundle Products - The options you selected are not available - MAGETWO-58035 [Backport] - Configurable product options not saved when editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic has a problem if the depth of the xml path is more than five, for example, try old cache node in local.xml. Fixed with a key check. By the way, how to add memcache support for magento2?