Skip to content

#13685: Upgrading jQuery to 3.3.1 #14556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kirmorozov
Copy link
Member

  • Updating jQuery to 3.3.1 (originally from npm)
  • Updating jQuery Migrate 3.0.1 (originally from npm)

Description

Upgrading initial jQuery and jQuery Migrate

Fixed Issues (if relevant)

  1. Incompatibilies with jQuery 3 #13685: Incompatibilies with jQuery 3
  2. ...

Manual testing scenarios

  1. I can checkout without any problems
  2. I can use admin without any problems

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

* Updating jQuery to 3.3.1 (originally from npm)
* Updating jQuery Migrate 3.0.1 (originally from npm)
* Test compatibility for with jQuery 3.x
* Updated jQuery UI to 1.12
+ moved plugin zIndex from previous version
* Fix ajax success in tests.
* Fixing Success/Error as towards done/fail in jQuery 3.x
* File upload success/fail
@kirmorozov
Copy link
Member Author

The jqXHR.success(), jqXHR.error(), and jqXHR.complete() callback methods are removed as of jQuery 3.0. You can use jqXHR.done(), jqXHR.fail(), and jqXHR.always() instead.
Latest

@okorshenko
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, here is your test Magento instance

@okorshenko
Copy link
Contributor

backend access: /admin admin @ 123123q

@okorshenko
Copy link
Contributor

Hi @kirmorozov thank you for PR. Unfortunately we can not accept this PR as is. We are in the middle for 2.3 regression + this is a backward incompatible change for us. It is ok to update usages for done fail always but without upgrading the library. Once all code is updated, we will be able to update the lib in 2.4. Could you please revert lib update?

* Update jQuery UI for backend.
Copy link
Contributor

@omiroshnichenko omiroshnichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pay attention on #14556 (comment).

@kirmorozov
Copy link
Member Author

@okorshenko Thanks for information PR can wait until you create 2.4-develop branch.
I have few more tests to fix.
And yes this it getting forwards to use 2 year old jQuery API.

@kirmorozov
Copy link
Member Author

@okobchenko @omiroshnichenko There are backward incompatible changes regarding ajax.
Following commits are compatible with 2.3 and do not break backward compatibility:
ccfdcbb
f9069b9
c4c93aa

Others are backward incompatible changes in jQuery 3.x.

@kirmorozov
Copy link
Member Author

Compatible code is cherry-picked in this pull request:
#14637

@ishakhsuvarov
Copy link
Contributor

Hi @kirmorozov
We are closing this PR now, due to reasons described in #14556 (comment).
Thank you for providing compatible change set with #14637

@kirmorozov
Copy link
Member Author

@ishakhsuvarov
Please provide 2.4-develop branch.

@ishakhsuvarov
Copy link
Contributor

@kirmorozov 2.4-develop will be available based on internal schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants