-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#13685: Upgrading jQuery to 3.3.1 #14556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updating jQuery to 3.3.1 (originally from npm) * Updating jQuery Migrate 3.0.1 (originally from npm)
* Test compatibility for with jQuery 3.x
* Updated jQuery UI to 1.12
+ moved plugin zIndex from previous version
* Fix ajax success in tests.
* Fixing Success/Error as towards done/fail in jQuery 3.x
* File upload success/fail
The jqXHR.success(), jqXHR.error(), and jqXHR.complete() callback methods are removed as of jQuery 3.0. You can use jqXHR.done(), jqXHR.fail(), and jqXHR.always() instead. |
@magento-engcom-team give me test instance |
Hi @okorshenko, here is your test Magento instance |
backend access: /admin admin @ 123123q |
Hi @kirmorozov thank you for PR. Unfortunately we can not accept this PR as is. We are in the middle for 2.3 regression + this is a backward incompatible change for us. It is ok to update usages for done fail always but without upgrading the library. Once all code is updated, we will be able to update the lib in 2.4. Could you please revert lib update? |
* Update jQuery UI for backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pay attention on #14556 (comment).
@okorshenko Thanks for information PR can wait until you create 2.4-develop branch. |
@okobchenko @omiroshnichenko There are backward incompatible changes regarding ajax. Others are backward incompatible changes in jQuery 3.x. |
Compatible code is cherry-picked in this pull request: |
Hi @kirmorozov |
@ishakhsuvarov |
@kirmorozov |
Description
Upgrading initial jQuery and jQuery Migrate
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist