Skip to content

#13685: Upgrading compatibility jQuery with 3.3.1 #14637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2018
Merged

#13685: Upgrading compatibility jQuery with 3.3.1 #14637

merged 3 commits into from
Apr 13, 2018

Conversation

kirmorozov
Copy link
Member

Description

Cherry-picked changes for jQuery 3 compatibility from #14556

Fixed Issues (if relevant)

  1. Incompatibilies with jQuery 3 #13685: Incompatibilies with jQuery 3
  2. ...

Manual testing scenarios

  1. I can checkout without any problems
  2. I can use admin without any problems

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@kirmorozov
magento#13685:
ae229f9 
* Test compatibility for with jQuery 3.x

(cherry picked from commit ccfdcbb)
@kirmorozov
magento#13685:
b25d28f 
* Fix ajax success in tests.

(cherry picked from commit 4c7df0a)
@kirmorozov
magento#13685:
ae43898 
* Fixing Success/Error as towards done/fail in jQuery 3.x

(cherry picked from commit 39d3b3a)
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kirmorozov kirmorozov changed the base branch from 2.2-develop to 2.3-develop April 11, 2018 10:37
@kirmorozov kirmorozov self-assigned this Apr 11, 2018
@kirmorozov kirmorozov mentioned this pull request Apr 11, 2018
Closed
4 tasks
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko, thank you for the review.
ENGCOM-1259 has been created to process this Pull Request

@kirmorozov
Copy link
Member Author

Is there way to run Travis?

@magento-engcom-team magento-engcom-team mentioned this pull request Apr 13, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ae43898 into magento:2.3-develop Apr 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 13, 2018
ENGCOM-1259: #13685: Upgrading compatibility jQuery with 3.3.1 #14637
11db4ca
@magento-engcom-team
Copy link
Contributor

Hi @kirmorozov. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@kirmorozov kirmorozov mentioned this pull request May 13, 2018
Closed
@kirmorozov kirmorozov mentioned this pull request May 26, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

@okorshenko okorshenko Awaiting requested review from okorshenko

Assignees

@kirmorozov kirmorozov

@omiroshnichenko omiroshnichenko

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@kirmorozov @magento-cicd2 @magento-engcom-team @omiroshnichenko