Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Newsletter Label is broking on chinese Language like 订阅. #17022

Merged
merged 1 commit into from
Jul 23, 2018
Merged

[Backport] Newsletter Label is broking on chinese Language like 订阅. #17022

merged 1 commit into from
Jul 23, 2018

Conversation

dasharath-wagento
Copy link
Contributor

@dasharath-wagento dasharath-wagento commented Jul 23, 2018 •
edited
Loading

Original Pull Request

#13029

When Set the newsletter subscribe button's title with at least two Chinese characters (either by changing it with your browser's Developer Tool or by switching the CMS language to Chinese), for instance "订阅". getting Wrap on Newsletter box.

Description

Fixed Issues (if relevant)

  1. Newsletter subscribe button title wrapped #12320: Newsletter subscribe button title wrapped

Manual testing scenarios

  1. Add two characters of the Chinese word "订阅" in translate for Newsletter "Subscribe"
    Actual Result:
    screenshot from 2018-01-07 10-56-07

Expected Result:
screenshot from 2018-01-07 10-57-42

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jul 23, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 23, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 23, 2018
@sidolov sidolov mentioned this pull request Jul 23, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit aad8cb7 into magento:2.1-develop Jul 23, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
ENGCOM-2477: [Backport] Newsletter Label is broking on chinese Langua…
c20d1c0 
…ge like 订阅. #17022
@magento-engcom-team
Copy link
Contributor

Hi @dasharath-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@dasharath-wagento @magento-cicd2 @magento-engcom-team @VladimirZaets