Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter subscribe button title wrapped #12320

Closed
gilles6 opened this issue Nov 17, 2017 · 10 comments
Closed

Newsletter subscribe button title wrapped #12320

gilles6 opened this issue Nov 17, 2017 · 10 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@gilles6
Copy link

gilles6 commented Nov 17, 2017

Preconditions

  1. Magento 2.2.1
  2. PHP 7.1

Steps to reproduce

Set the newsletter subscribe button's title with at least two Chinese characters (either by changing it with your browser's Developer Tool or by switching the CMS language to Chinese), for instance "订阅".

Expected result

The two characters of the Chinese word "订阅" should be written in the same line.
screen shot 2017-11-17 at 16 37 12

Actual result

The Chinese word "订阅" is wrapped in two lines.
screen shot 2017-11-17 at 16 36 56

I fixed the issue temporarily by adding the following CSS in the file web/css/source/_extend.less of my custom theme.

button.action.subscribe.primary {
  white-space: nowrap;
}
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 17, 2017
@magento-engcom-team
Copy link
Contributor

@Gvigner, thank you for your report.
We've created internal ticket(s) MAGETWO-84056 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 17, 2017
@dasharath-wagento
Copy link
Contributor

dasharath-wagento:“#mm18in”

@magento-engcom-team
Copy link
Contributor

@dasharath-wagento thank you for joining. Please accept team invitation here and self-assign the issue.

@monaemipro
Copy link

Please assign me this issue #MM18IN

@magento-engcom-team
Copy link
Contributor

@monaemipro thank you for joining. Please accept team invitation here and self-assign the issue.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@magento-team
Copy link
Contributor

Hi @Gvigner. Thank you for your report.
The issue has been fixed in #13041 by @monaemipro in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team
Copy link
Contributor

Hi @Gvigner. Thank you for your report.
The issue has been fixed in #13029 by @dasharath-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Gvigner. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1302 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@okorshenko
Copy link
Contributor

Hi @Gvigner. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1380 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov
Copy link
Contributor

sidolov commented Jul 23, 2018

Hi @Gvigner. Thank you for your report.
The issue has been fixed in #17022 by @dasharath-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants