Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter Label is broking on chinese Language like 订阅 #13029

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Newsletter Label is broking on chinese Language like 订阅 #13029

merged 2 commits into from
Jan 10, 2018

Conversation

dasharath-wagento
Copy link
Contributor

When Set the newsletter subscribe button's title with at least two Chinese characters (either by changing it with your browser's Developer Tool or by switching the CMS language to Chinese), for instance "订阅". getting Wrap on Newsletter box.

Description

Fixed Issues (if relevant)

  1. Newsletter subscribe button title wrapped #12320: Newsletter subscribe button title wrapped

Manual testing scenarios

  1. Add two characters of the Chinese word "订阅" in translate for Newsletter "Subscribe"
    Actual Result:
    screenshot from 2018-01-07 10-56-07

Expected Result:
screenshot from 2018-01-07 10-57-42

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 7, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dmanners dmanners added the mm18in label Jan 7, 2018
@ishakhsuvarov
Copy link
Contributor

Hi @dasharath-wagento
Please sign the CLA so that we could proceed with the review and merge of the PR.
Thanks!

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 7, 2018
@ishakhsuvarov
Copy link
Contributor

Thanks @dasharath-wagento

@ishakhsuvarov ishakhsuvarov self-assigned this Jan 7, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 7, 2018
@okorshenko okorshenko self-assigned this Jan 9, 2018
@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@magento-team magento-team mentioned this pull request Jan 10, 2018
Closed
@magento-team magento-team merged commit 294c09e into magento:2.2-develop Jan 10, 2018
magento-team pushed a commit that referenced this pull request Jan 10, 2018
MAGETWO-86436: Newsletter Label is broking on chinese Language like 订阅 …
cb21b8f 
…#13029
@chirag-wagento chirag-wagento mentioned this pull request Jul 18, 2018
Merged
4 tasks
@mage2pratik mage2pratik mentioned this pull request Jul 21, 2018
Closed
4 tasks
@dasharath-wagento dasharath-wagento mentioned this pull request Jul 23, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

@okorshenko okorshenko

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
7 participants
@dasharath-wagento @magento-cicd2 @ishakhsuvarov @magento-team @dmanners @okorshenko @magento-engcom-team