[Backport] Newsletter Label is broking on chinese Language like 订阅 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able Qty Increments' filed in product import
Add missing showInStore attributes on Braintree configuration as there are some values that are changeable on store view (Title, Descriptors, merchant name override) and are not accessible from store view level.
…tes magento#16550 - Merge Pull Request magento#16550 from e-conomix/magento2:2.1-braintree-backport - Merged commits: 1. 6d79c64
…e \`Enable Qty Increments\` field magento#14380 - Merge Pull Request magento#14380 from simpleadm/magento2:backport/2.1-fix-product-import-enable-qty-inc - Merged commits: 1. ead41d9 2. 053fea2
…t page] magento#16526 - Merge Pull Request magento#16526 from hitesh-wagento/magento2:2.1-wrong-password-checkout - Merged commits: 1. 86ed9df 2. b5902e9
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759 - Merge Pull Request magento#16759 from mageprince/magento2:2.1-develop-PR-port-16699 - Merged commits: 1. 9f06c5f 2. d6e647d
… in Magento_Sales and Magento_Paypal magento#16760 - Merge Pull Request magento#16760 from mageprince/magento2:2.1-develop-PR-port-16698 - Merged commits: 1. db30595
… in Magento_Sales and Magento_Paypal magento#16760
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759
Accepted Public Pull Requests: - magento#16760: [Backport] Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince) - magento#16759: [Backport] Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax (by @mageprince) - magento#16550: [Backport magento#16458] Add missing showInStore attributes (by @aschrammel)
magento#16761 - Merge Pull Request magento#16761 from gelanivishal/magento2:2.1-develop-PR-port-15346-2 - Merged commits: 1. 7a6217c
…ree module's template file. magento#16770 - Merge Pull Request magento#16770 from sanganinamrata/magento2:2.1-develop-PR-port-16690 - Merged commits: 1. 48530d2
…ssue magento#16755 - Merge Pull Request magento#16755 from Karlasa/magento2:BP-PR-16716 - Merged commits: 1. f7160a2
…e `Enable Qty Increments` field magento#14380
Accepted Public Pull Requests: - magento#16761: [Backport] Fix function unnecessarily called multiple time (by @gelanivishal) - magento#16526: [Backport : Changed password placeholder text in checkout page] (by @hitesh-wagento) - magento#14380: [Backport 2.1] Issue 14351: Product import doesn't change `Enable Qty Increments` field (by @simpleadm) Fixed GitHub Issues: - magento#15355: Function is unnecessarily called multiple time (reported by @saurabh-aureate) has been fixed in magento#16761 by @gelanivishal in 2.1-develop branch Related commits: 1. 7a6217c - magento#16378: Wrong placeholder for password field in the checkout page (reported by @mohitka) has been fixed in magento#16526 by @hitesh-wagento in 2.1-develop branch Related commits: 1. 86ed9df 2. b5902e9 - magento#14351: Product import doesn't change `Enable Qty Increments` field (reported by @simpleadm) has been fixed in magento#14380 by @simpleadm in 2.1-develop branch Related commits: 1. ead41d9 2. 053fea2
The e-mail address is responding with an autoreply which tells to use bugcrowd. So just mention bugcrowd instead so people don't loose time typing & encrypting a mail which has no use.
…mples block magento#16825 - Merge Pull Request magento#16825 from ronak2ram/magento2:2.1-develop-PR-port-16408 - Merged commits: 1. 6698036 2. 82150c6
…magento#16835 - Merge Pull Request magento#16835 from mage2pratik/magento2:2.1-develop-PR-port-16566 - Merged commits: 1. 5a9fef2
Accepted Public Pull Requests: - magento#16825: [Backport] Fixed type hints and docs for Downloadable Samples block (by @ronak2ram) - magento#16836: [Backport] Fixed typo in SynonymGroupRepositoryInterface (by @mage2pratik) - magento#16755: [backport] magento#16716 fix _utilities.less font-size issue (by @Karlasa)
…nto#16842 - Merge Pull Request magento#16842 from gelanivishal/magento2:2.1-develop-PR-port-15305 - Merged commits: 1. 93304cc
…order status history comment magento#16846 - Merge Pull Request magento#16846 from ronak2ram/magento2:2.1-develop-PR-port-15637 - Merged commits: 1. 876315e 2. 3fc48e9
…t detail Page. magento#16839 - Merge Pull Request magento#16839 from Karlasa/magento2:PP-PR-16766 - Merged commits: 1. 8e4cda6
- Merge Pull Request magento#16832 from gelanivishal/magento2:2.1-develop-PR-port-15825 - Merged commits: 1. 305aa0b 2. b36a0ab
…order status history comment magento#16846
Accepted Public Pull Requests: - magento#16839: [backport] fix magento#16764 Rating Star issue on Product detail Page. (by @Karlasa) - magento#16846: [Backport] Create ability to set is_visible_on_front to order status history comment (by @ronak2ram) - magento#16842: [Backport] chore: remove extraneous cursor property (by @gelanivishal) - magento#16832: [Backport] Fixed set template syntax issue (by @gelanivishal) Fixed GitHub Issues: - magento#16764: Rating Star issue on Product detail Page. (reported by @Sathishkumar8731) has been fixed in magento#16839 by @Karlasa in 2.1-develop branch Related commits: 1. 8e4cda6
…ree module's template file. magento#16770
Accepted Public Pull Requests: - magento#16770: [Backport] Added translation function for Magento_Braintree module's template file. (by @sanganinamrata)
Accepted Public Pull Requests: - magento#16835: [Backport] Smallest codestyle fix in Option/Type/Text.php (by @mage2pratik) - magento#16828: [Backport] FIX for apparently random API failures while using array types (by @ronak2ram) - magento#16802: [Backport] magento#16685 Updated security issues details (by @quisse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13029
When Set the newsletter subscribe button's title with at least two Chinese characters (either by changing it with your browser's Developer Tool or by switching the CMS language to Chinese), for instance "订阅". getting Wrap on Newsletter box.
Description
Fixed Issues (if relevant)
Manual testing scenarios
Actual Result:
Expected Result:
Contribution checklist