-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow module dependencies to not be "hard" dependencies. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, forgot to mention the commit is not tested.. :-o |
The feature has been implemented in the development repository along with tests, it will become available with the next Github updates. |
magento-team
added a commit
that referenced
this pull request
Jun 7, 2012
* Fixed various crashes of visual design editor * Fixed some layouts that caused visual design editor toolbar disappearing, also fixed some confusing page type labels * Eliminated "after commit callback" workaround from integration tests by implementing "transparent transactions" capability in integration testing framework * Refactored admin authentication/authorization in RSS module. Removed program termination and covered the controllers with tests * Removed HTML-report feature of copy-paste detector which never worked anyway (`dev/tests/static/framework/Inspection/CopyPasteDetector/html_report.xslt` and all related code) * Github requests: ** [#19](#19) Implemented "soft" dependency between modules and performed several improvements in the related code, covered with tests
Closing request as implemented. Thank you for the suggestion. |
Posted a link to this page from my blog. Great explanation. http://webdev.vanrij.org/index.php/2013/08/19/replayce-old-javascript-version-in-magento/ |
Closed
Closed
Closed
Closed
ghost
mentioned this pull request
Aug 19, 2022
5 tasks
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 31, 2022
[Amigos] Community Contributions – Patch 8
5 tasks
5 tasks
5 tasks
Closed
5 tasks
5 tasks
5 tasks
This was referenced Feb 17, 2023
5 tasks
5 tasks
Open
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
ghost
mentioned this pull request
May 13, 2024
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would sometimes be very helpful to use the module "depends" feature to force ordering of module loading, without explicitly requiring the other modules. For example, if module A breaks when module B is loaded after module A, but A works fine if B is not present, then it would be nice for module A to have a "soft" dependency on module B. That is, do not require module B to be loaded, but if it is loaded, make sure module B is loaded first.
In the xml this would look like:
Although this is a pull request I understand that you may want different attribute naming, xml semantics, etc. Please let me know what you think or if you want me to make any changes. Thanks!