Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[32017] Marked interfaces as API #32160

Closed
wants to merge 587 commits into from
Closed

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32017

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark Directory, Downloadable, Eav and Elasticsearch interfaces as API #32017

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

gabrieldagama and others added 30 commits December 16, 2020 09:05
MC-39756: An image added to the Content via Page Builder is not counted in "Used In" counter.
…se Order Final Checkout Page

 - Cleaning up changes for StorefrontPlaceOrderFromPurchaseOrderUsingOnlinePaymentMethodTest
…ect_shipping_address_on_purchase_order_final_checkout_page
…t_shipping_address_on_purchase_order_final_checkout_page

534 incorrect shipping address on purchase order final checkout page
- Added composer2 support
- Added composer2 support
MC-39997: fix graphql category performance degradation
[trigger] MC-39996: Add composer2 support
[Arrows] MC-39985: Request error when displaying content on CMS page of second website
[TR] Update CE, EE to fix constraint for magento-composer-installer
… Configurable product (magento#6474)

* MC-39990: Unexpected displayed visual swatch attribute of the Configurable product
gabrieldagama and others added 19 commits February 11, 2021 11:28
Fixed adding product with option to wishlist
 - Fixing tests that are causing PR failures
[Arrows] Fixes for 2.4 (pr123) (2.4-develop)
 - Fixing tests that are causing PR failures
@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 15, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 15, 2021
@Usik2203 Usik2203 closed this Feb 15, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.