String "Place Order" is not pulled from the Checkout module

[amenk]

The Place Order button is a Mage_Core_Block_Template instance and so the __ function tries to pull the translation from Mage_Core, not from Mage_Checkout as it is defined in the translation files.

[amenk]

This is of a quite high importance as in Germany there are laws that allow only specific namings of the button that are not in effect because of this bug.

[Forestsoft-de]

Yeah right. This Bug exists since Mage 1.4.x Made me confused.

[magento-team]

@amenk
Thank you for the valuable contribution. Proposed code changes have been incorporated into the internal repository, necessary tests have been added as well. Next time please supply pull requests with automated tests (unit or integration).

Changes will become available on the GitHub with one of the next merges from the internal repository.

Closing the ticket as complete. Thank you.

[amenk]

Thanks for accepting my contribution. I am a little bit confused: How would an test for pulling a translation string look like??? Can you give an example?

[magento-team]

Sure, here is a test using integration testing framework:

/**
 * @magentoConfigFixture current_store general/locale/code de_DE
 */
public function testReviewActionLocalization()
{
    $this->dispatch('checkout/onepage/review');
    $this->assertNotContains('Place Order', $this->getResponse()->getBody());
    $this->assertContains('Bestellung aufgeben', $this->getResponse()->getBody());
}

It will be available in one of next code updates.

We'd like to mention that this test is not ideal. The best fit for this case probably would be a combination of functional and unit test. But at the moment we don't publish functional tests and some Magento legacy code is nearly impossible to cover with unit test without substantial refactoring.