Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor translation fixes #96

Closed
wants to merge 3 commits into from
Closed

Conversation

barbazul
Copy link
Contributor

@barbazul barbazul commented Oct 1, 2012

Several translation-related minor fixes.

Mostly translation strings being pulled from the wrong file

@magento-team
Copy link
Contributor

@barbazul
Thank you for raising the issues with translates.

Fixes have been incorporated into the internal repository with deviations and automated tests, where applicable.

Code changes will be available after one of the next code publications to the GitHub from the internal repository.

Closing as complete. Thank you.

magento-team added a commit that referenced this pull request Nov 12, 2012
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * CAPTCHA
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
magento-team pushed a commit that referenced this pull request Feb 20, 2015
magento-team pushed a commit that referenced this pull request Nov 1, 2015
okorshenko pushed a commit that referenced this pull request Jun 12, 2016
…llation-of-ee-fails

[Extensibility] MAGETWO-54120: Installation fails
magento-engcom-team pushed a commit that referenced this pull request Apr 13, 2018
MAGETWO-89350: php version in composer.json of some components is inconsistent with php version in root composer.json
magento-engcom-team added a commit that referenced this pull request Jul 24, 2018
 - Merge Pull Request magento/graphql-ce#99 from magento/graphql-ce:96-compatibility-with-content-staging
 - Merged commits:
   1. e79f381
magento-engcom-team pushed a commit that referenced this pull request Jul 24, 2018
Accepted Public Pull Requests:
 - #16893: [Forwardport] FIX for issue#14869 - Wrong price at backend after update (by @mage2pratik)
 - #17020: [Forwardport] hide cookie notice instead of reloading site (by @torhoehn)
 - #17014: [Forwardport] Fixes white color coding standard. (by @chirag-wagento)
 - #17016: [Forwardport] Avoid undefined index warning when using uppercase reserved word (by @FreekVandeursen)
 - #17017: [Forwardport] Wrong namespace defined in compare.phtml (by @ronak2ram)
 - #16997: [Forwardport] Corrected Magento_Framework's test xml file. (by @ihor-sviziev)
 - #16996: [Forwardport] Updated Magento_Newsletter's block file. (by @ihor-sviziev)
 - #16994: [Forwardport] Responsive Design Footers bottom of screen on mobile devices #15118 (by @ihor-sviziev)
 - #16993: [Forwardport] FIXED - appended payment code to ID field to make it unique (by @ihor-sviziev)
 - #16998: [Forwardport] Added 'title' attribute to 'a' link. (by @ihor-sviziev)
 - #16973: [Forwardport] Removed double occurrence of  keywords in sentences. (by @gelanivishal)
 - magento/graphql-ce#126: 120 implement store configs coverage (by @VitaliyBoyko)
 - magento/graphql-ce#99: #96 Make category query compatible with staging (by @roma-glushko)
 - #16734: [forwardport] #16559 fix icon color variable naming  (by @Karlasa)


Fixed GitHub Issues:
 - #14869: M 2.2.3 price per website - wrong price at backend by a create order after update (reported by @Webroju) has been fixed in #16893 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 49926d7
     2. 35b968e

 - #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices (reported by @gwharton) has been fixed in #16994 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. f7228d0

 - #13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method (reported by @NeosKnowledgeBasePluswerk) has been fixed in #16993 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. a659f4b

 - #120: Default trigger coupon via URL (reported by @seansan) has been fixed in magento/graphql-ce#126 by @VitaliyBoyko in 2.3-develop branch
   Related commits:
     1. e1f53d4
     2. 5229cd6
     3. af4b258
     4. 3b64955
     5. b5a2a98
     6. e85a6e5
     7. 8f3c6e9
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 9, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2019
Pushing MC-20335 changes to MC-19451 branch
magento-devops-reposync-svc pushed a commit that referenced this pull request May 6, 2023
* LYNX-100: Initial implementation

* LYNX-100: Refa ctoring; GraphQl tests

* LYNX-100: Refactoring

* LYNX-100: Refactoring tests

* LYNX-100: Refactoring; fix WebAPI tests

* LYNX-100: Refactoring

* LYNX-100: Refactoring

* LYNX-100: Refactoring

* LYNX-100: Refactoring

* LYNX-100: CR changes; bugfixing; refactoring

* LYNX-100: Remove whitespaces

* LYNX-100: Fix WebAPI tests

* LYNX-100: Fix WebAPI tests

* LYNX-100: Refactoring; fix static tests

* LYNX-100: Refactoring; bugfixing

* LYNX-100: Remove newlines

* LYNX-100: Fix static tests

* LYNX-100: Return UNDEFINED for frontend_input if not set for attribute

* LYNX-100: Fix static test

* LYNX-100: CR changes

* LYNX-100: CR changes

* LYNX-100: CR changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants