[PB] Page Builder #1872

davemacaulay · 2019-10-09T18:04:37Z

Description

Introduce Page Builder support to PWA Studio

Related Issue

https://jira.corp.magento.com/browse/PB-1

Verification Steps

Check that each property for each content type appearance renders correctly on PWA Venia storefront in desktop and mobile.
Compare Venia PWA rendering of content type with Luma to ensure the experience is the same or better for each property of each appearance in desktop and mobile.
Check each supported browser and on mobile that is supported according to PWA documentation.
Acceptable performance has been validated

- make it prettier

- Update tests for associated content types

- Update tests

WIP pagebuilder docs setup in menu, etc.

# Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/__tests__/parseStorageHtml.spec.js

- Prettier

[PB] Master format parser for PWA Studio

[PB] Row component

[PB] Image Component

# Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Image/image.js

- Fix tests

- Include cleanup in useEffect hook

…into PB-19 # Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/config.js # packages/venia-ui/package.json # yarn.lock

- Fix failing test

…into PB-38

- Remove dead code path

- Add configAggregator.spec.js

jimbo

(3 of 4) (150 of 202 files reviewed)

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Products/products.js

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Row/row.js

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Slider/slider.css

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Slider/slider.js

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/TabItem/tabItem.css

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Tabs/tabs.js

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Video/video.css

jimbo

(4 of 4) (202 / 202 files reviewed)

packages/venia-ui/lib/components/RichContent/PageBuilder/factory.js

Updated Known limitations

…n-bug [PB] Resolve bugs in Row & Column component

Fixes from markdown linting

Moved images into image directory

Moved all Page Builder docs to _drafts

awilcoxa · 2019-10-18T16:51:31Z

Appears homepage content is broken on develop if this is merged, we should resolve any issue that breaks current app functionality prior to merging.

jimbo

@davemacaulay Thanks for making all of those changes. This looks really good now. 👍

I noticed two more minor things, but otherwise we're good to go.

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Tabs/tabs.js

davemacaulay · 2019-10-18T18:15:18Z

@awilcoxa @jimbo

Appears homepage content is broken on develop if this is merged, we should resolve any issue that breaks current app functionality prior to merging.

We've added some logic to show the category list if the page is empty or it has default content.

e35b463#diff-68c0ddcfb13cfa542ddc32f37857f438R30-R39

jimbo

Approving this from my end. Nice work all around. 👍

@dpatil-magento I think we can move this into your court now.

davemacaulay · 2019-10-18T18:40:07Z

Approving this from my end. Nice work all around. 👍

@dpatil-magento I think we can move this into your court now.

Thanks @jimbo!

@dhaecker will QA this from our perspective before merging , @dpatil-magento there's no need for you to QA this (unless you wish too).

[PB][Docs] PB-36: Creating custom Page Builder components

dhaecker

QA approved

zetlen · 2019-10-18T21:06:45Z

HONK HONK

cspruiell and others added 30 commits September 24, 2019 15:10

PB-15: Image content type in Venia UI / PWA Studio

cf5c5fc

- make it prettier

PB-5: WYSIWYG Image optimization in PWA

c3150a3

- Update tests for associated content types

PB-5: WYSIWYG Image optimization in PWA

0682f86

- Update tests

PB-11: Heading content type in Venia UI / PWA Studio

14f2747

PB-35: [Docs] Master format parsing

71e3f9d

WIP pagebuilder docs setup in menu, etc.

Merge branch 'feature/page-builder' into PB-4

4598358

Merge branch 'PB-4' into PB-5

b794c54

# Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/__tests__/parseStorageHtml.spec.js

PB-11: Heading content type in Venia UI / PWA Studio

cc96e17

PB-4: Master format parser for PWA Studio

8b3343a

Merge branch 'PB-4' into PB-5

70c9445

PB-5: WYSIWYG Image optimization in PWA

efdee79

- Prettier

PB-4: Master format parser for PWA Studio

5d12808

Merge pull request #1777 from magento-obsessive-owls/PB-4

9e2c880

[PB] Master format parser for PWA Studio

Merge branch 'feature/page-builder' into PB-5

708e930

Merge branch 'feature/page-builder' into PB-15-image

43a23ee

Merge pull request #1753 from magento-obsessive-owls/PB-2

f9bbf88

[PB] Row component

Merge pull request #1770 from magento-obsessive-owls/PB-15-image

683b9e0

[PB] Image Component

PB-19: Map content type in Venia UI / PWA Studio

26fa35d

Merge branch 'feature/page-builder' into PB-5

1ef470b

# Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Image/image.js

PB-5: WYSIWYG Image optimization in PWA

5f32c0d

- Fix tests

PB-38: [Docs] Initial setup in PWA docs

7a602be

PB-19: Map content type in Venia UI / PWA Studio

453640a

- Include cleanup in useEffect hook

Merge remote-tracking branch 'remotes/mainline/feature/page-builder' …

37d9df2

…into PB-19 # Conflicts: # packages/venia-ui/lib/components/RichContent/PageBuilder/config.js # packages/venia-ui/package.json # yarn.lock

PB-34: Implement hide / show functionality for all content types

3047976

PB-20: Block content type in Venia UI / PWA Studio

114ed96

- Fix failing test

Merge branch 'feature/page-builder' into PB-38

e92b4ae

Merge remote-tracking branch 'origin' into PB-38

e1183b1

Merge branch 'PB-38' of github.com:magento-obsessive-owls/pwa-studio …

7bc905c

…into PB-38

PB-19: Map content type in Venia UI / PWA Studio

d4f4567

- Remove dead code path

PB-19: Map content type in Venia UI / PWA Studio

f4c4d68

- Add configAggregator.spec.js

jimbo suggested changes Oct 17, 2019

View reviewed changes

packages/venia-ui/lib/components/RichContent/PageBuilder/factory.js Outdated Show resolved Hide resolved

davemacaulay and others added 9 commits October 18, 2019 08:41

Merge branch 'develop' into feature/page-builder

6716949

PB-36: [Docs] Creating custom Page Builder components

a4b9836

Updated Known limitations

Merge pull request #1900 from magento-obsessive-owls/PB-167-row-colum…

aee010f

…n-bug [PB] Resolve bugs in Row & Column component

Refactor tabs useState to useRef, remove box sizing, refactor cssClasses

dc8fb48

Fix formatting

7159757

Object destructure dynamic import

140c343

PB-36: [Docs] Creating custom Page Builder components

f0e1e61

Fixes from markdown linting

PB-36: [Docs] Creating custom Page Builder components

c45a3e8

Moved images into image directory

PB-36: [Docs] Creating custom Page Builder components

d11fc37

Moved all Page Builder docs to _drafts

jimbo suggested changes Oct 18, 2019

View reviewed changes

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Tabs/tabs.js Outdated Show resolved Hide resolved

packages/venia-ui/lib/components/RichContent/PageBuilder/ContentTypes/Tabs/tabs.js Outdated Show resolved Hide resolved

davemacaulay added 2 commits October 18, 2019 12:50

Resolve event names and callback dep

50cbc1f

Render <CategoryList /> if page content is empty or default

e35b463

jimbo previously approved these changes Oct 18, 2019

View reviewed changes

Merge pull request #1897 from magento-obsessive-owls/PB-36

4d72f9f

[PB][Docs] PB-36: Creating custom Page Builder components

davemacaulay dismissed jimbo’s stale review via 4d72f9f October 18, 2019 19:23

jcalcaben approved these changes Oct 18, 2019

View reviewed changes

jimbo approved these changes Oct 18, 2019

View reviewed changes

davemacaulay requested a review from dhaecker October 18, 2019 20:30

dhaecker approved these changes Oct 18, 2019

View reviewed changes

zetlen merged commit 404cd2c into develop Oct 18, 2019

m2-community-project bot removed the Progress: changes requested label Oct 18, 2019

sirugh deleted the feature/page-builder branch March 4, 2020 18:43

sirugh mentioned this pull request Mar 17, 2021

[doc]: Instructions on how to display backend homepage (from CMS) as a homepage for Venia #3033

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PB] Page Builder #1872

[PB] Page Builder #1872

davemacaulay commented Oct 9, 2019 •

edited

Loading

jimbo left a comment

jimbo left a comment

awilcoxa commented Oct 18, 2019

jimbo left a comment

davemacaulay commented Oct 18, 2019

jimbo left a comment

davemacaulay commented Oct 18, 2019 •

edited

Loading

dhaecker left a comment

zetlen commented Oct 18, 2019

[PB] Page Builder #1872

[PB] Page Builder #1872

Conversation

davemacaulay commented Oct 9, 2019 • edited Loading

Description

Related Issue

Verification Steps

jimbo left a comment

Choose a reason for hiding this comment

jimbo left a comment

Choose a reason for hiding this comment

awilcoxa commented Oct 18, 2019

jimbo left a comment

Choose a reason for hiding this comment

davemacaulay commented Oct 18, 2019

jimbo left a comment

Choose a reason for hiding this comment

davemacaulay commented Oct 18, 2019 • edited Loading

dhaecker left a comment

Choose a reason for hiding this comment

zetlen commented Oct 18, 2019

davemacaulay commented Oct 9, 2019 •

edited

Loading

davemacaulay commented Oct 18, 2019 •

edited

Loading