Fix for issue #8 #11
Closed
Fix for issue #8 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that GetPowerStationPowerAndIncomeByDay returns figures for multiple dates. Hence this "fix" in order to ensure that the correct one is taken into account. The code could probably be cleaner but knowing that it is not 100% sur how the GoodWe API works, it is robust as such.
|
Tested as working on my side |
|
Should be fixed in release 1.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that GetPowerStationPowerAndIncomeByDay returns figures for multiple dates.
Hence this "fix" in order to ensure that the correct one is taken into account.
The code could probably be cleaner but knowing that it is not 100% sur how the GoodWe API works, it is robust as such.