Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of MSC3824 to add action= param on SSO login #2398

Merged
merged 16 commits into from
Sep 11, 2022
Merged

Implementation of MSC3824 to add action= param on SSO login #2398

merged 16 commits into from
Sep 11, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented May 24, 2022 •
edited by github-actions bot
Loading

Here's what your changelog entry will look like:

✨ Features

@hughns hughns mentioned this pull request May 24, 2022
Open
9 tasks
@hughns hughns marked this pull request as ready for review August 4, 2022 18:16
@hughns hughns requested a review from a team as a code owner August 4, 2022 18:16
turt2live
turt2live reviewed Aug 4, 2022
View reviewed changes
SimonBrandner
SimonBrandner approved these changes Aug 5, 2022
View reviewed changes
weeman1337
weeman1337 suggested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughns can you add a test for it?

@hughns
Copy link
Member Author

hughns commented Sep 1, 2022

@hughns can you add a test for it?

I've added some some simple test cases.

@hughns hughns requested a review from weeman1337 September 1, 2022 18:38
weeman1337
weeman1337 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hughns hughns enabled auto-merge (squash) September 11, 2022 21:08
@hughns hughns merged commit a57c430 into develop Sep 11, 2022
@hughns hughns deleted the hughns/msc3824-sso-action branch September 11, 2022 21:18
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Sep 28, 2022
@su-ex
Merge tag 'v19.6.0' into sc
cb81a65 
* Add a property aggregating all names of a NamespacedValue ([\matrix-org#2656](matrix-org#2656)).
* Implementation of MSC3824 to add action= param on SSO login ([\matrix-org#2398](matrix-org#2398)). Contributed by @hughns.
* Add invited_count and joined_count to sliding sync room responses. ([\matrix-org#2628](matrix-org#2628)).
* Base support for MSC3847: Ignore invites with policy rooms ([\matrix-org#2626](matrix-org#2626)). Contributed by @Yoric.
* Fix handling of remote echoes doubling up ([\matrix-org#2639](matrix-org#2639)). Fixes matrix-org#2618.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@weeman1337 weeman1337 weeman1337 approved these changes

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hughns @turt2live @weeman1337 @SimonBrandner