sliding sync: add invited|joined_count #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is critical for calculating client-side push rules correctly. Without it, the push processor may think rooms have a different number of members, resulting typically in annoying failure modes where rooms constantly make noises because the code thinks they are 1:1 rooms.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Sep 28, 2022
* Add a property aggregating all names of a NamespacedValue ([\matrix-org#2656](matrix-org#2656)). * Implementation of MSC3824 to add action= param on SSO login ([\matrix-org#2398](matrix-org#2398)). Contributed by @hughns. * Add invited_count and joined_count to sliding sync room responses. ([\matrix-org#2628](matrix-org#2628)). * Base support for MSC3847: Ignore invites with policy rooms ([\matrix-org#2626](matrix-org#2626)). Contributed by @Yoric. * Fix handling of remote echoes doubling up ([\matrix-org#2639](matrix-org#2639)). Fixes matrix-org#2618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is critical for calculating client-side push rules correctly.
Without it, the push processor may think rooms have a different
number of members, resulting typically in annoying failure modes
where rooms constantly make noises because the code thinks they
are 1:1 rooms.
Checklist
Notes: add invited_count and joined_count to sliding sync room responses.
Here's what your changelog entry will look like:
✨ Features