Base support for MSC3847: Ignore invites with policy rooms #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
force-pushed
the
yoric/ignore-invites-3847
branch
from
28619da
to
641c593
Compare
Yoric
force-pushed
the
yoric/ignore-invites-3847
branch
2 times, most recently
from
7de2554
to
12e9077
Compare
duxovni
approved these changes
Aug 31, 2022
I can do that. I don't see any scenario for using this method in the near future, except perhaps for testing, though. |
|
I took the opportunity to add a few more tests. |
Yoric
force-pushed
the
yoric/ignore-invites-3847
branch
from
9600ca8
to
2023e36
Compare
|
Are we waiting for any further reviews or can this be merged? |
turt2live
requested changes
Sep 5, 2022
Yoric
force-pushed
the
yoric/ignore-invites-3847
branch
from
bb90191
to
335cf9f
Compare
3 tasks
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Sep 28, 2022
* Add a property aggregating all names of a NamespacedValue ([\matrix-org#2656](matrix-org#2656)). * Implementation of MSC3824 to add action= param on SSO login ([\matrix-org#2398](matrix-org#2398)). Contributed by @hughns. * Add invited_count and joined_count to sliding sync room responses. ([\matrix-org#2628](matrix-org#2628)). * Base support for MSC3847: Ignore invites with policy rooms ([\matrix-org#2626](matrix-org#2626)). Contributed by @Yoric. * Fix handling of remote echoes doubling up ([\matrix-org#2639](matrix-org#2639)). Fixes matrix-org#2618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second take on the matrix-js-sdk-level machinery needed to be able to ignore invites, this time based on MSC3847.
The intention is that decisions on whether/how to display ignored invites is left in the hands of matrix-react-sdk.
Checklist
Type: enhancement
Here's what your changelog entry will look like:
✨ Features