Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide deactivated users in iOS #8092

Closed
wants to merge 108 commits into from
Closed

Hide deactivated users in iOS #8092

wants to merge 108 commits into from

Conversation

Juliet879
Copy link

Summary

Do now show deactivated users in iOS Mobile

Ticket Link

#8074

Device Information

This PR was tested on: iPhone 15 Pro

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-07-15 at 12 36 39

Release Note

NONE

cpoile and others added 30 commits May 10, 2024 16:43
@cpoile
[MM-58129] Calls: Host controls remove participant, view profile (#7938)
7fbd2e5 
* host remove command, host removed feedback

* add view profile control

* i18n; dismissBottomSheet later

* PR comments

* remove confusing setPreviousCall(null)

* our own separator, bit more space for Android

* no need for previousCall due to changes on server

* move host removed alert to an error

* channel_id is not send via the msg.broadcast

* channel_id is still sent via the msg.broadcast
@cpoile
[MM-57460] - Calls: Host controls, add mute all to participant list (#…
59db183 
…7945)

* add mute all to participant list

* i18n

* hostControlsAvailable

* mute-all -> mute-others
@mattermost-build
Translated using Weblate (Polish)
ee5e24d 
Currently translated at 100.0% (1127 of 1127 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/pl/
@johnsonbrothers @mattermost-build
Translated using Weblate (Swedish)
5189605 
Currently translated at 100.0% (1127 of 1127 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/sv/
@jprusch @mattermost-build
Translated using Weblate (German)
6ac3b75 
Currently translated at 100.0% (1127 of 1127 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/de/
@kaakaa @mattermost-build
Translated using Weblate (Japanese)
bff2169 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/ja/
@mattermost-build
Translated using Weblate (Polish)
3489bb2 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/pl/
@mvitale1989
Bump app build number to 521 (#7952)
7b14ea2 
Co-authored-by: runner <runner@Mac-1715329932711.local>
@amyblais
Update README.md (#7946)
08c3825 
* Update README.md

* Update full_description.txt

* Update changelog
@mvitale1989
Move away from curl and jq for the version bump script (#7957)
2d66605
@unified-ci-app
Bump app build and version number (#7959)
32e4e0a 
* Bump app build number to 522

* Bump app version number to 2.17.0

---------

Co-authored-by: runner <runner@Mac-1715946646591.local>
@weblate @jprusch
Translations update from Mattermost Weblate (#7962)
aecd50c 
* Translated using Weblate (German)

Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/de/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/nl/

---------

Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
@cpoile
[MM-57291] Calls: Add channel name to call header (#7968)
5e1c75f
@cpoile
[MM-57267] Calls: Update post UI (#7965)
3f7fa8b 
* MM-58259 - allow current host to run /end call; fix deprecated test fns

* update call card UI

* update call ended icon

* make joinCall async; adding loading spinner to join/start button

* Revert "make joinCall async; adding loading spinner to join/start button"

This reverts commit bbb1366.

* shadowRadius 3 -> 1
@mvitale1989
Fix MILESTONE_FOUND command (#7972)
1206309
@unified-ci-app
Bump app build number to 523 (#7974)
c00bf9c 
Co-authored-by: runner <runner@Mac-1716820087705.local>
@weblate @mattermost-build
Update translation files
21dcf36 
Updated by "Cleanup translation files" hook in Weblate.

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/
@ThrRip @mattermost-build
Translated using Weblate (Chinese (Simplified))
a78a9f2 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/zh_Hans/
@orimaimon @mattermost-build
Translated using Weblate (Hebrew)
23e41a1 
Currently translated at 4.1% (47 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/he/
@jprusch @mattermost-build
Translated using Weblate (German)
4a6c572 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/de/
@matt-w99 @mattermost-build
Translated using Weblate (English (Australia))
6bca4f3 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/en_AU/
@mattermost-build
Translated using Weblate (Polish)
b594a47 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/pl/
@johnsonbrothers @mattermost-build
Translated using Weblate (Swedish)
a5a8ab7 
Currently translated at 99.3% (1128 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/sv/
@mattermost-build
Translated using Weblate (Dutch)
b241e61 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/nl/
@johnsonbrothers @mattermost-build
Translated using Weblate (Swedish)
5a661cd 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/sv/
@larkox
Fix user autocomplete not always showing on search screen (#7977)
663f9ba
@enahum
fix update image on account screen when updating profile image (#7978)
83e4aba
@larkox
Fix user autocomplete not showing users not in channel (#7980)
9628e15
@unified-ci-app
Bump app build number to 525 (#7987)
0473c1b 
Co-authored-by: runner <runner@Mac-1717409210410.local>
@weblate
Translated using Weblate (Russian) (#7988)
cf254f8 
Currently translated at 100.0% (1135 of 1135 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/ru/

Co-authored-by: Konstantin <eleferen@gmail.com>
weblate and others added 25 commits July 2, 2024 15:53
@weblate @kaakaa
Translations update from Mattermost Weblate (#8053)
1f6194d 
* Translated using Weblate (Russian)

Currently translated at 100.0% (1140 of 1140 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/ru/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (1140 of 1140 strings)

Translation: Mattermost/mattermost-mobile-v2
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-mobile-v2/ja/

---------

Co-authored-by: Konstantin <eleferen@gmail.com>
Co-authored-by: kaakaa <stooner.hoe@gmail.com>
@ckaznable
Fix User Agent issue in some device (#8049)
331d313 
* Remove deviceName from User Agent

* Use modelName for User Agent
@cpoile @mattermost-build @enahum
[MM-57486] [MM-58008] Calls: Mobile ringing for incoming calls (#7984)
92bdb28 
* notification ringing, settings screen, native code patch, ringing mp3s

* i18n

* play preview on first press

* prevent playing from background (only affects Android) to match iOS beh

* stop ringing/vibration on entering background

* ring when coming back from background and new incoming call is present

* no push notification sound when it's a call; improve ringing

* move sounds to asset folder; copy on postinstall for android bundling

* make Ringtone type a string enum

* make Android ring async + await ring and stop; changes from PR comments

* missing fields after merge

* release lock on an exception

* cancel sample ringing when turning notifications off

* copy sound files for android build

* typo

* update snapshots

* testing if the problem is copying the mp3 files

* fix android mp3 assets when building for non-release

* add sounds to .gitignore

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
@enahum
added utils unit tests (#8040)
a722447
@larkox
Graciously handle load measure when there is no mark (#8052)
095b974 
* Graciously handle load measure when there is no mark

* Make public interface cleaner
@jwilander
Add unit tests for app/actions/local/category (#8058)
2c29172 
* Add unit tests for app/actions/local/category

* Remove unnecessary forEach

* Run setup only once
@jwilander
Add unit tests for app/actions/local/channel (#8063)
dd3a38b 
* Add tests for actions/local/channel/removeCurrentUserFromChannel

* Add tests for actions/local/channel/setChannelDeleteAt

* Add tests for actions/local/channel/selectAllMyChannelIds

* Add tests for actions/local/channel/markChannelAsUnread

* Add tests for actions/local/channel/resetMessageCount

* Add tests for actions/local/channel/storeMyChannelsForTeam

* Fix test names

* Add tests for actions/local/channel/updateMyChannelFromWebsocket

* Add tests for actions/local/channel/updateChannelInfoFromChannel

* Add tests for actions/local/channel/updateLastPostAt

* Add tests for actions/local/channel/updateChannelsDisplayName

* Add tests for actions/local/channel/showUnreadChannelsOnly

* Add tests for actions/local/channel/updateDmGmDisplayName

* Remove unnecessary spying
@weblate
Translations update from Mattermost Weblate (#8065)
17d15c6 
Automatic Merge
@unified-ci-app
Bump app build number to 532 (#8048)
773fcc3 
Co-authored-by: runner <runner@Mac-1719563817324.local>
@enahum
Fix button ui when disabled (#8056)
1013509
@larkox
Restore out of channel and some cleanup (#8050)
f3de444 
* Restore out of channel and some cleanup

* Fix i18n
@jwilander
Update jest config to show coverage for correct folders (#8069)
8c44c54
@mvitale1989
Add Amy as a reviewer for the weekly build number bump PRs (#8071)
0fbeea8 
* Add Amy as a reviewer for the weekly build number bump PRs

* PR_REVIEWERS is a comma-separated list
@rahimrahman
fix: add mkdir of "android/app/src/main/res/raw/" in postinstall (#8070)
b9f4000
@enahum
more utils unit test coverage (#8068)
9bdb5c1
@jwilander @enahum @yasserfaraazkhan
Add unit tests for app/actions/local/draft (#8067)
6031e8d 
* Add tests for actions/local/draft/updateDraftFile

* Add tests for actions/local/draft/removeDraftFile

* Add tests for actions/local/draft/updateDraftMessage

* Add tests for actions/local/draft/addFilesToDraft

* Add tests for actions/local/draft/removeDraft

* Add tests for actions/local/draft/updateDraftPriority

* Fix updateDraftMessage test case

* Update app/actions/local/draft.test.ts

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>

* place common beforeeach/aftereach top of file (#8076)

---------

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>
@jwilander
Add unit tests for app/actions/local/file and app/actions/local/group (…
333b594 
…#8077)

* Add tests for actions/local/file

* Add tests for actions/local/group
@unified-ci-app
Bump app build number to 535 (#8082)
c3dc4c6 
Co-authored-by: runner <runner@Mac-1720773707918.local>
@saturninoabril
fix: saving e2e test report in Zephyr (#8080)
8fb0b32
@jwilander
Add tests for actions/local/post (#8083)
3c6d5aa
@saturninoabril
test: app/actions/app/global.ts (#8087)
58b50b1
@enahum
add file utils unit tests (#8079)
e4d8d11
@pvev
MM-56933 - password dont disable autocomplete (#8057)
d02e39b
@yasserfaraazkhan
Add unit test cases for reactions.ts (#8084)
cdaae87
@weblate
Translations update from Mattermost Weblate (#8089)
62a694b 
Automatic Merge
@mattermost-build
Copy link
Contributor

Hello @Juliet879,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

panicking
panicking suggested changes Jul 16, 2024
View reviewed changes
app/components/user_item/user_item.tsx Outdated
@@ -121,6 +121,10 @@ const UserItem = ({
const shared = user ? isShared(user) : false;
const deactivated = user ? isDeactivated(user) : false;

if(deactivated) {
return null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (deactivated) I think that you should follow the style

@Juliet879 Juliet879 closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panicking panicking panicking requested changes

Assignees
No one assigned
Labels
Contributor release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.