Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(Code Issue): Code Issue in /modules/carts-and-checkout/backend/add-payment-provider #5424

Closed
1 of 2 tasks
99power opened this issue Oct 19, 2023 · 1 comment · Fixed by #5429
Closed
1 of 2 tasks

Docs(Code Issue): Code Issue in /modules/carts-and-checkout/backend/add-payment-provider #5424

99power opened this issue Oct 19, 2023 · 1 comment · Fixed by #5429
Labels
type: docs

Comments

@99power
Copy link

99power commented Oct 19, 2023

Preliminary Checks

Issue Summary

Getting an error when using the example or following the docs for the payment processor: Non-abstract class 'MyPaymentProcessor' does not implement inherited abstract member 'updatePaymentData' from class 'AbstractPaymentProcessor'.

How can this issue be resolved?

  1. Add updatePaymentData to the Docs and the example code
  2. Remove updatePaymentData to be mandatory (not sure what it does)

Are you interested in working on this issue?

  • I would like to fix this issue
@shahednasser
Copy link
Member

Thank you for reporting this! The updatePaymentData is missing from the documentation. Will open a PR to add it shortly.

In the meantime, you can check how it's implemented in the Stripe plugin as an example. Sorry for the inconvenience!

shahednasser added a commit that referenced this issue Oct 20, 2023
@shahednasser
fixes #5424
b1b47e3
@shahednasser shahednasser mentioned this issue Oct 20, 2023
Merged
shahednasser added a commit that referenced this issue Oct 20, 2023
@shahednasser
docs: general fixes and enhancements (#5429)
83f46b9 
* fix #5427

* fixes #5424

* add new s3 option

* make learning path steps clickable

* remove admin demo link

* fix documentation job conditions

* update user guide images

* update commerce modules titles to match their respective pages

* change icon of discount card

* change ref to head_ref in action condition

* remove refs prefix

* fix vale action's condition
riqwan pushed a commit that referenced this issue Oct 23, 2023
@shahednasser @riqwan
docs: general fixes and enhancements (#5429)
cae2b75 
* fix #5427

* fixes #5424

* add new s3 option

* make learning path steps clickable

* remove admin demo link

* fix documentation job conditions

* update user guide images

* update commerce modules titles to match their respective pages

* change icon of discount card

* change ref to head_ref in action condition

* remove refs prefix

* fix vale action's condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: general fixes and enhancements medusajs/medusa
2 participants
@shahednasser @99power