Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(Code Issue): Code Issue in /plugins/payment/stripe #5427

Closed
1 of 2 tasks
JaydenWN opened this issue Oct 19, 2023 · 1 comment · Fixed by #5429
Closed
1 of 2 tasks

Docs(Code Issue): Code Issue in /plugins/payment/stripe #5427

JaydenWN opened this issue Oct 19, 2023 · 1 comment · Fixed by #5429
Labels
type: docs

Comments

@JaydenWN
Copy link

Preliminary Checks

Issue Summary

https://docs.medusajs.com/plugins/payment/stripe

Under custom storefront 'implement the workflow'

isStripeAvailable is checking for processor_id, cart.payment_sessions uses provider_id

How can this issue be resolved?

  1. Replace session.processor_id with session.provider_id

...

Are you interested in working on this issue?

  • I would like to fix this issue
@shahednasser
Copy link
Member

Thank you for submitting this issue! Will open a PR to fix it

shahednasser added a commit that referenced this issue Oct 20, 2023
@shahednasser
fix #5427
7018293
@shahednasser shahednasser mentioned this issue Oct 20, 2023
Merged
shahednasser added a commit that referenced this issue Oct 20, 2023
@shahednasser
docs: general fixes and enhancements (#5429)
83f46b9 
* fix #5427

* fixes #5424

* add new s3 option

* make learning path steps clickable

* remove admin demo link

* fix documentation job conditions

* update user guide images

* update commerce modules titles to match their respective pages

* change icon of discount card

* change ref to head_ref in action condition

* remove refs prefix

* fix vale action's condition
riqwan pushed a commit that referenced this issue Oct 23, 2023
@shahednasser @riqwan
docs: general fixes and enhancements (#5429)
cae2b75 
* fix #5427

* fixes #5424

* add new s3 option

* make learning path steps clickable

* remove admin demo link

* fix documentation job conditions

* update user guide images

* update commerce modules titles to match their respective pages

* change icon of discount card

* change ref to head_ref in action condition

* remove refs prefix

* fix vale action's condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: general fixes and enhancements medusajs/medusa
2 participants
@shahednasser @JaydenWN