Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/11.4.1 #6083

Merged
merged 17 commits into from
Nov 27, 2024
Merged

Release/11.4.1 #6083

merged 17 commits into from
Nov 27, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

This pull request includes various fixes and improvements to the mermaid and @mermaid-js/layout-elk packages. The most important changes focus on bug fixes, dependency updates, and enhancements to diagram rendering.

Bug Fixes:

  • Fixed Kanban diagrams to render correctly when adding a number as the ticket ID or assigned for a task (.changeset/eleven-rocks-leave.md).
  • Fixed intersection calculations for tilted cylinders/DAS when using the hand-drawn look, which previously broke with some random seeds (.changeset/fresh-bears-doubt.md).
  • Fixed Elk rendering of Diamond shape intersections (.changeset/nervous-beans-listen.md).

Dependency Updates:

  • Bumped dompurify to ^3.2.1, removing the need for @types/dompurify (.changeset/neat-rabbits-bake.md, packages/mermaid/package.json, pnpm-lock.yaml) [1] [2] [3] [4] [5].

Enhancements:

  • Added tests for handling diamond shape intersections in flowcharts (cypress/integration/rendering/flowchart-elk.spec.js) [1] [2].
  • Improved the render function to handle small epsilon values and better log output (packages/mermaid-layout-elk/src/render.ts) [1] [2] [3] [4] [5] [6] [7] [8].
  • Enhanced DOMPurify hooks and sanitation in common.ts (packages/mermaid/src/diagrams/common/common.ts) [1] [2].
  • Ensured that various node properties in Kanban diagrams are converted to strings (packages/mermaid/src/diagrams/kanban/kanbanDb.ts).

These changes collectively improve the stability and functionality of the diagram rendering and related features in the mermaid and @mermaid-js/layout-elk packages.

Resolves #6080 , #6058 , #6037

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

ashishjain0512 and others added 17 commits November 7, 2024 12:14
Merge back v4.11.0 to develop
fix:Kanban diagrams will not render when adding a number as ticket id or assigned for a task
As [DOMPurify 3.2.0 added TypeScript types][1], this means that we can
remove our dependency on the `@types/dompurify` package.

[DOMPurify 3.2.0 also adds the `HTML_INTEGRATION_POINTS` option][2],
which adds back support for `<foreignObject>`,
[which broke in DOMPurify 3.1.7.][3]

[1]: https://github.com/cure53/DOMPurify/releases/tag/3.2.0
[2]: cure53/DOMPurify@e4caa67
[3]: de2c05c
fix: update dompurify to `^3.2.1` and remove `@types/dompurify`
fix: Elk rendering of Diamond shape intersections
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 0dff4ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/layout-elk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 0dff4ca
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6746e235dcf4c40008028dc5
😎 Deploy Preview https://deploy-preview-6083--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 merged commit 0b4f852 into master Nov 27, 2024
26 of 41 checks passed
@sidharthv96 sidharthv96 deleted the release/11.4.1 branch November 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants