Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to fix krona plots #51

Merged
merged 4 commits into from
Aug 26, 2024
Merged

PR to fix krona plots #51

merged 4 commits into from
Aug 26, 2024

Conversation

daulet-a
Copy link
Contributor

@daulet-a daulet-a commented Aug 23, 2024

Summary

Small PR to fix krona plots

Details

Changes

  • 6e8aebe Added metadata as input when samplesheet
  • 783b288 Started ignoring build/ in .gitignore
  • e4218e7 Hard-coded "Sample" column name in krona table

Fixes

@daulet-a daulet-a requested a review from farchaab August 23, 2024 14:47
Copy link
Contributor

@farchaab farchaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@farchaab farchaab added the bug Something isn't working label Aug 26, 2024
@farchaab farchaab merged commit be61e64 into master Aug 26, 2024
@farchaab farchaab deleted the fix-krona branch August 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KRONA plots not grouped by samples
2 participants