EBAS reading: add tests for correct values for the most used EBAS variables

[jgriesfeller]

The current EBAS reading tests do not test actual variable values.
I think we should also make sure that the read values of the most used variables make sense.
Variables:

• concso4
• concso2
• concpm10
• concpm25
• conco3
• concoa
• concss
• concoc

[lewisblake]

Some guidance for criteria for "makes sense" would be appreciated here. In my initial testing, I've found concpm10 concentrations with negative values (all -0.1), but can't seem to find an obvious way to determine if these are fill values or suspect data.

[lewisblake]

It is also worth noting that the ReasEbas filter itself does not check for negative values in the data.

[avaldebe]

@jgriesfeller

It is also worth noting that the ReasEbas filter itself does not check for negative values in the data.

Do you k now if this is a bug or a feature?

[lewisblake]

I think it's a feature. It's listed:

TODO
----
- Check for negative values vs. detection limit
- ...

I looked to see if this was just outdated and had been implemented but this TODO not removed, but I did not see anything which appears like it has been implemented. I think we should implement removing of negative values before testing for it :)

[avaldebe]

Is there an specific issue for the negative values?
If not, maybe you could open one and address it on your test coverage PR?

[lewisblake]

I do not see an issue, so I will open one and address it.

[github-actions]

This issue is stale because it has been open for 365 days with no activity. This issue will be closed in 14 days if no action is taken.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.