Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for negative values in EBAS Reader #708

Closed
lewisblake opened this issue Jul 21, 2022 · 2 comments · Fixed by #722
Closed

Check for negative values in EBAS Reader #708

lewisblake opened this issue Jul 21, 2022 · 2 comments · Fixed by #722
Assignees

Comments

@lewisblake
Copy link
Member

#605 would like use to include test which ensure that the values read from EBAS make sense. However, filtering of spurious data is not yet implemented in ReadEbas. At the very least, ReadEbas should not read in values with negative concentrations, VMRS, or any species which a negative value is non-physical.

@lewisblake
Copy link
Member Author

lewisblake commented Jul 21, 2022

This is not such an obvious problem, because negative values are appropriate for some EBAS species (e.g., scattering coefficients). We therefore need to have more species-specific criteria for filtering of observations.

Note: Check vs detection limit

@dulte
Copy link
Collaborator

dulte commented Sep 5, 2022

Let this be up to the users. Maybe with some documentation(?)

lewisblake added a commit that referenced this issue Sep 5, 2022
@lewisblake lewisblake linked a pull request Sep 5, 2022 that will close this issue
lewisblake added a commit that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants