Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #696

Merged
merged 55 commits into from
Aug 4, 2022
Merged

Increase test coverage #696

merged 55 commits into from
Aug 4, 2022

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jul 6, 2022

Beginning an effort (not the last) to increase our test coverage. I will include fixes as I identify them.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #696 (b57eb08) into main-dev (8464e42) will increase coverage by 2.66%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           main-dev     #696      +/-   ##
============================================
+ Coverage     77.38%   80.04%   +2.66%     
============================================
  Files            97       97              
  Lines         17561    17422     -139     
============================================
+ Hits          13589    13946     +357     
+ Misses         3972     3476     -496     
Flag Coverage Δ
unittests 80.04% <100.00%> (+2.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/griddeddata.py 70.86% <ø> (+9.56%) ⬆️
pyaerocom/io/aux_read_cubes.py 66.04% <ø> (+39.26%) ⬆️
pyaerocom/io/helpers.py 72.03% <ø> (+1.54%) ⬆️
pyaerocom/ungriddeddata.py 69.99% <ø> (+8.12%) ⬆️
pyaerocom/varnameinfo.py 90.16% <ø> (+52.45%) ⬆️
pyaerocom/aux_var_helpers.py 59.61% <100.00%> (+1.92%) ⬆️
pyaerocom/io/helpers_units.py 85.18% <100.00%> (+67.53%) ⬆️
pyaerocom/region.py 71.01% <0.00%> (+0.72%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lewisblake
Copy link
Member Author

Note to self: possibly include #605

@lewisblake
Copy link
Member Author

Address #708

@lewisblake lewisblake marked this pull request as ready for review August 4, 2022 07:29
@lewisblake lewisblake requested a review from avaldebe August 4, 2022 07:29
@lewisblake
Copy link
Member Author

Think this is at a good place to merge for now. Can always return to this effort, but I think we've hit a milestone with over 80% coverage

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.
Please remove dead code and split valid/invalid test cases.

pyaerocom/io/helpers.py Outdated Show resolved Hide resolved
pyaerocom/io/read_ebas.py Outdated Show resolved Hide resolved
pyaerocom/ungriddeddata.py Outdated Show resolved Hide resolved
pyaerocom/varnameinfo.py Outdated Show resolved Hide resolved
tests/aeroval/test_coldatatojson_helpers2.py Outdated Show resolved Hide resolved
tests/test_ungriddeddata.py Outdated Show resolved Hide resolved
tests/test_ungriddeddata.py Outdated Show resolved Hide resolved
tests/test_varnameinfo.py Outdated Show resolved Hide resolved
tests/test_varnameinfo.py Outdated Show resolved Hide resolved
tests/test_varnameinfo.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small nitpick regarding one of the tests

tests/test_varnameinfo.py Outdated Show resolved Hide resolved
@lewisblake lewisblake requested a review from avaldebe August 4, 2022 12:50
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎆 ready to merge

@lewisblake lewisblake merged commit c419649 into main-dev Aug 4, 2022
@lewisblake lewisblake deleted the increase_test_coverage branch November 29, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants