-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage #696
Conversation
Codecov Report
@@ Coverage Diff @@
## main-dev #696 +/- ##
============================================
+ Coverage 77.38% 80.04% +2.66%
============================================
Files 97 97
Lines 17561 17422 -139
============================================
+ Hits 13589 13946 +357
+ Misses 3972 3476 -496
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Note to self: possibly include #605 |
Address #708 |
Think this is at a good place to merge for now. Can always return to this effort, but I think we've hit a milestone with over 80% coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
Please remove dead code and split valid/invalid test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one small nitpick regarding one of the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎆 ready to merge
Beginning an effort (not the last) to increase our test coverage. I will include fixes as I identify them.