Updates to Ranges test machinery #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2020
CaseyCarter
changed the title
Contributor
|
This manages to both look great and create a terrible headache for all the coming merge conflicts |
Contributor
Author
@StephanTLavavej has been calling me "Merge Conflict" for years now. |
Member
|
Back when @BillyONeal and @CaseyCarter were in the same office, and were constantly submitting PRs with merge conflicts against each other, I placed a sticky note over their office nameplate, dubbing them Billy "Merge" O'Neal and Casey "Conflict" Carter. 😹 |
StephanTLavavej
approved these changes
Jul 1, 2020
CaseyCarter
commented
Jul 2, 2020
Merged
mnatsuhara
approved these changes
Jul 2, 2020
* The point is to break the abstraction and provide access to the internal pointer. There's no reason to mimic the behavior of iterator/sentinel adaptors, it just makes the test tool harder to use. * Enforce that `begin` is called at most once in `test::range::_Unchecked_begin` * Remove default arguments to the `test_meow` functions in `<range_algorithm_support.hpp>`.
StephanTLavavej
approved these changes
Jul 2, 2020
mnatsuhara
approved these changes
Jul 2, 2020
StephanTLavavej
approved these changes
Jul 2, 2020
Member
|
Thanks for making it easier to test ranges! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
basemember oftest::iteratorandtest::sentinelwithpeek. The point is to break the abstraction and provide access to the internal pointer. There's no reason to mimic the behavior of iterator/sentinel adaptors, it just makes the test tool harder to use.test::range::beginenforces the restriction that it may be called at most once for a single-pass range.test::range::_Unchecked_beginshould be subject to the same restriction.Remove default template arguments for the element types of ranges in the instantiation helpers (
test_in,test_fwd_fwd, etc.) forcing the element types to be explicitly specified.