fix: allowJs and checkJs shouldn't be relatedTo emitDeclarationOnly #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove emitDeclarationOnly from their relatedTo and group them separately from declaration by adding a newline - these only seem quite loosely related, only by the DTS/JS doc - c.f. https://github.com/microsoft/TypeScript-Website/blob/2a57f7116b72217e47550657826cd650d258ba20/packages/documentation/copy/en/javascript/Creating%20DTS%20files%20From%20JS.md#L46 - the relationship is not even mentioned in their notes or otherwise in the Reference, which was very confusing to me - the commit that adds this relationship seems to put `emitDeclarationOnly` elsewhere too, so maybe this was a mistake? - c.f. microsoft@4627aa3#diff-a912c6af3a16bf4288093c1264955bc6R75
agilgur5
force-pushed
the
fix-remove-emitDeclarationOnly-relatedTo
branch
from
e08b0e2 to
3af3a1b
Compare
|
Yeah, this one I'd like to keep - I think they're related in the sense that I'd want people using a tsconfig with JS to know that they can get TS to emit d.ts files for them and that this flag is kinda essential in allowing that to happen. |
|
Followed up on this (like ~2 years later, my to-do list really stretches out...) with #2395 to implement the alternative of linking to the DTS/JS doc instead to explain the relationship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove emitDeclarationOnly from their relatedTo and group them
separately from declaration by adding a newline
these only seem quite loosely related, only by the DTS/JS doc
TypeScript-Website/packages/documentation/copy/en/javascript/Creating DTS files From JS.md
Line 46 in 2a57f71
in the Reference, which was very confusing to me
emitDeclarationOnlyelsewhere too, so maybe this was a mistake?Tags
Found while writing #1095 / #971
These relationships seem to have been originally added in #163 here
Review Notes
If this was an intentional
relatedTo, feel free to close this. If so, then a link to the DTS/JS doc should probably be added from the Reference in order to explain this relationship instead.