fix: ensure strict checks are all recommended and related to #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
strictPropertyInitialization and alwaysStrict were missing from
recommended even though the other Strict Checks were in there and all
of them are enabled if strict is enabled
alwaysStrict, strictNullChecks, noImplicitAny, and noImplicitThis were
missing from strict's relatedTo even though all are enabled if strict
is enabled
Tags
Found while working on #970.
Related to another PR I had on the topic of Strict Checks, #500
Review Notes
They're all listed as "recommended", but
strict
enables all of them and is the only one turned on in@tsconfig/recommend
and bytsc --init
, so maybe all of them should be removed from "recommended" except forstrict
instead? Thoughts?