Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing inverses in relatedTo #1099

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Sep 17, 2020

Description

  • one side of the relationship existed but not the other side, ensure
    both sides of the relationship are relatedTo each other for proper
    backlinking etc

  • add a new line after all the strict options for proper grouping same
    as the other groups

Tags

Found while writing #1095 / #971

Review Notes

I omitted allowJs and checkJs from emitDeclarationOnly's relatedTo because of #1098 , but can add them if that PR is rejected

- one side of the relationship existed but not the other side, ensure
  both sides of the relationship are relatedTo each other for proper
  backlinking etc

- add a new line after all the strict options for proper grouping same
  as the other groups
@orta
Copy link
Contributor

orta commented Sep 17, 2020

Great, thanks!

@orta orta merged commit f30907a into microsoft:v2 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants