chore: bump jest to 29.7.0 #29298
Merged
chore: bump jest to 29.7.0 #29298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
added
Area: Build System
dependencies
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac07deb:
|
Hotell
force-pushed
the
hotell/jest/29-7-0
branch
from
6afd5fe
to
e9b40ed
Compare
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 633 | 609 | 5000 | |
| Button | mount | 306 | 311 | 5000 | |
| Field | mount | 1116 | 1094 | 5000 | |
| FluentProvider | mount | 685 | 686 | 5000 | |
| FluentProviderWithTheme | mount | 72 | 83 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 57 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 77 | 10 | |
| InfoButton | mount | 12 | 11 | 5000 | |
| MakeStyles | mount | 846 | 865 | 50000 | |
| Persona | mount | 1735 | 1649 | 5000 | |
| SpinButton | mount | 1380 | 1320 | 5000 |
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 88 | 74 | 1.19:1 |
| PortalMinimalPerf.default | 89 | 80 | 1.11:1 |
| ButtonOverridesMissPerf.default | 683 | 625 | 1.09:1 |
| PopupMinimalPerf.default | 375 | 351 | 1.07:1 |
| TreeWith60ListItems.default | 93 | 88 | 1.06:1 |
| DropdownManyItemsPerf.default | 389 | 371 | 1.05:1 |
| BoxMinimalPerf.default | 194 | 187 | 1.04:1 |
| ChatWithPopoverPerf.default | 186 | 179 | 1.04:1 |
| ListMinimalPerf.default | 307 | 296 | 1.04:1 |
| LoaderMinimalPerf.default | 197 | 189 | 1.04:1 |
| IconMinimalPerf.default | 385 | 369 | 1.04:1 |
| TooltipMinimalPerf.default | 1300 | 1248 | 1.04:1 |
| TreeMinimalPerf.default | 469 | 452 | 1.04:1 |
| AvatarMinimalPerf.default | 109 | 106 | 1.03:1 |
| CardMinimalPerf.default | 303 | 295 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 703 | 681 | 1.03:1 |
| MenuButtonMinimalPerf.default | 957 | 928 | 1.03:1 |
| SegmentMinimalPerf.default | 189 | 184 | 1.03:1 |
| SliderMinimalPerf.default | 757 | 732 | 1.03:1 |
| CarouselMinimalPerf.default | 261 | 256 | 1.02:1 |
| DividerMinimalPerf.default | 201 | 197 | 1.02:1 |
| GridMinimalPerf.default | 188 | 185 | 1.02:1 |
| HeaderSlotsPerf.default | 468 | 460 | 1.02:1 |
| ListWith60ListItems.default | 368 | 360 | 1.02:1 |
| SkeletonMinimalPerf.default | 198 | 194 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2247 | 2193 | 1.02:1 |
| StatusMinimalPerf.default | 397 | 389 | 1.02:1 |
| TableManyItemsPerf.default | 1098 | 1074 | 1.02:1 |
| ToolbarMinimalPerf.default | 531 | 519 | 1.02:1 |
| AnimationMinimalPerf.default | 293 | 290 | 1.01:1 |
| DatepickerMinimalPerf.default | 3530 | 3479 | 1.01:1 |
| DialogMinimalPerf.default | 440 | 435 | 1.01:1 |
| ListNestedPerf.default | 318 | 314 | 1.01:1 |
| MenuMinimalPerf.default | 491 | 487 | 1.01:1 |
| VideoMinimalPerf.default | 427 | 424 | 1.01:1 |
| ButtonMinimalPerf.default | 86 | 86 | 1:1 |
| ButtonSlotsPerf.default | 312 | 311 | 1:1 |
| ChatDuplicateMessagesPerf.default | 146 | 146 | 1:1 |
| ChatMinimalPerf.default | 429 | 428 | 1:1 |
| CheckboxMinimalPerf.default | 1117 | 1113 | 1:1 |
| DropdownMinimalPerf.default | 1431 | 1427 | 1:1 |
| EmbedMinimalPerf.default | 1859 | 1861 | 1:1 |
| LabelMinimalPerf.default | 211 | 210 | 1:1 |
| RosterPerf.default | 1505 | 1508 | 1:1 |
| CustomToolbarPrototype.default | 1459 | 1455 | 1:1 |
| FormMinimalPerf.default | 206 | 209 | 0.99:1 |
| ProviderMergeThemesPerf.default | 650 | 655 | 0.99:1 |
| ProviderMinimalPerf.default | 197 | 198 | 0.99:1 |
| ReactionMinimalPerf.default | 206 | 208 | 0.99:1 |
| TableMinimalPerf.default | 236 | 239 | 0.99:1 |
| FlexMinimalPerf.default | 151 | 154 | 0.98:1 |
| InputMinimalPerf.default | 517 | 530 | 0.98:1 |
| LayoutMinimalPerf.default | 191 | 194 | 0.98:1 |
| RadioGroupMinimalPerf.default | 255 | 259 | 0.98:1 |
| AttachmentSlotsPerf.default | 616 | 635 | 0.97:1 |
| ListCommonPerf.default | 387 | 400 | 0.97:1 |
| AlertMinimalPerf.default | 154 | 160 | 0.96:1 |
| RefMinimalPerf.default | 108 | 113 | 0.96:1 |
| HeaderMinimalPerf.default | 196 | 206 | 0.95:1 |
| ImageMinimalPerf.default | 210 | 223 | 0.94:1 |
| TextAreaMinimalPerf.default | 270 | 287 | 0.94:1 |
| AccordionMinimalPerf.default | 79 | 85 | 0.93:1 |
| TextMinimalPerf.default | 180 | 193 | 0.93:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b5d527237289d185bd58e4500a04f9d3d495662a (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 634 | 617 | 5000 | |
| Breadcrumb | mount | 1666 | 1645 | 1000 | |
| Checkbox | mount | 1668 | 1680 | 5000 | |
| CheckboxBase | mount | 1468 | 1485 | 5000 | |
| ChoiceGroup | mount | 2874 | 2922 | 5000 | |
| ComboBox | mount | 654 | 656 | 1000 | |
| CommandBar | mount | 6184 | 6293 | 1000 | |
| ContextualMenu | mount | 14645 | 14727 | 1000 | |
| DefaultButton | mount | 744 | 742 | 5000 | |
| DetailsRow | mount | 2210 | 2204 | 5000 | |
| DetailsRowFast | mount | 2161 | 2172 | 5000 | |
| DetailsRowNoStyles | mount | 2016 | 1960 | 5000 | |
| Dialog | mount | 2627 | 2630 | 1000 | |
| DocumentCardTitle | mount | 224 | 223 | 1000 | |
| Dropdown | mount | 1942 | 2022 | 5000 | |
| FocusTrapZone | mount | 1128 | 1155 | 5000 | |
| FocusZone | mount | 1078 | 1077 | 5000 | |
| GroupedList | mount | 37152 | 41872 | 2 | |
| GroupedList | virtual-rerender | 19905 | 19985 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51352 | 50830 | 2 | |
| GroupedListV2 | mount | 236 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 207 | 211 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 217 | 232 | 2 | |
| IconButton | mount | 1096 | 1065 | 5000 | |
| Label | mount | 337 | 341 | 5000 | |
| Layer | mount | 2697 | 2729 | 5000 | |
| Link | mount | 380 | 383 | 5000 | |
| MenuButton | mount | 946 | 961 | 5000 | |
| MessageBar | mount | 21291 | 21374 | 5000 | |
| Nav | mount | 1943 | 1935 | 1000 | |
| OverflowSet | mount | 773 | 773 | 5000 | |
| Panel | mount | 1762 | 1796 | 1000 | |
| Persona | mount | 743 | 776 | 1000 | |
| Pivot | mount | 888 | 869 | 1000 | |
| PrimaryButton | mount | 856 | 836 | 5000 | |
| Rating | mount | 4620 | 4614 | 5000 | |
| SearchBox | mount | 899 | 917 | 5000 | |
| Shimmer | mount | 1868 | 1874 | 5000 | |
| Slider | mount | 1307 | 1319 | 5000 | |
| SpinButton | mount | 2855 | 2866 | 5000 | |
| Spinner | mount | 383 | 386 | 5000 | |
| SplitButton | mount | 1825 | 1772 | 5000 | |
| Stack | mount | 407 | 413 | 5000 | |
| StackWithIntrinsicChildren | mount | 867 | 864 | 5000 | |
| StackWithTextChildren | mount | 2604 | 2598 | 5000 | |
| SwatchColorPicker | mount | 6052 | 6083 | 5000 | |
| TagPicker | mount | 1430 | 1415 | 5000 | |
| Text | mount | 376 | 382 | 5000 | |
| TextField | mount | 958 | 922 | 5000 | |
| ThemeProvider | mount | 833 | 818 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 587 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1259 | 1255 | 5000 | |
| Toggle | mount | 608 | 623 | 5000 | |
| buttonNative | mount | 191 | 195 | 5000 |
Hotell
force-pushed
the
hotell/jest/29-7-0
branch
from
e9b40ed
to
731db8b
Compare
github-actions
bot
modified the milestones:
September Project Cycle Q4 2023,
October Project Cycle Q4 2023
Hotell
commented
Oct 18, 2023
| @@ -45,7 +45,7 @@ exports[`LineChart - mouse events Should render callout correctly on mouseover 1 | |||
| "display": "block", | |||
| } | |||
| } | |||
| width={100} | |||
| width={108} | |||
There was a problem hiding this comment.
Dunno what is happening here but this looks like not the most robust approach to approach tests.
It would be great to change this long term. also there are dozens of errors being triggered because react-charting is not using act as needed within tests.
cc @AtishayMsft - if you're ok with these changes lets merge it and unblock everyone else. your team can provide proper fixes afterwards. WDYT ?
There was a problem hiding this comment.
Agreed. Upgrading jest version should not break test snapshots.
We have encountered some issues with the test platform in the past and had to workaround those.
Is this the only test that failed?
We can file a bug and let this upgrade proceed. The act issue is on our radar but not prioritized yet.
@srmukher Could you log a bug for this on the charting side.
Hotell
commented
Oct 19, 2023
| undefined, | ||
| beforeAll, | ||
| ); | ||
| // @FIXME - this is failing on CI / not failing on local machine |
There was a problem hiding this comment.
this is getting bit out of control tbh. non deterministic snapshots generated on local vs CI environment.
cc @AtishayMsft
-
Local: all passes
-
CI:
There was a problem hiding this comment.
@srmukher is looking into this.
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run Visual Regression Tool - PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ing after jest 29.7 bump + are non deterministic on local vs CI environment
Hotell
force-pushed
the
hotell/jest/29-7-0
branch
from
ef04dff
to
d93dda2
Compare
…re failing after jest 29.7 bump + are non deterministic on local vs CI environment
AtishayMsft
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Approving for changes in charting package. I have logged an issue #29607 to track this at Charting end.
ling1726
approved these changes
Oct 20, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 24, 2023
* master: (48 commits) fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524) feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536) feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597) feat: (breadcrumb) Removed appearance prop (microsoft#29554) chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476) Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395) applying package updates applying package updates chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603) docs: Add guidance for modifying textarea's height. (microsoft#29601) fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611) [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608) chore: bump jest to 29.7.0 (microsoft#29298) applying package updates feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585) feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587) feat: adds motion to DialogSurface (microsoft#29391) fix: Use correct target windows for ResizeObserver (microsoft#29551) chg (microsoft#29592) Fix missing x callout custom callout (microsoft#29547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
See PR title
Related Issue(s)