feat(react-infolabel, react-components): Release InfoLabel to stable #29585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 68 | 63 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 619 | 622 | 5000 | |
| Button | mount | 314 | 322 | 5000 | |
| Field | mount | 1112 | 1110 | 5000 | |
| FluentProvider | mount | 692 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 63 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 84 | 10 | |
| InfoButton | mount | 11 | 15 | 5000 | |
| MakeStyles | mount | 849 | 874 | 50000 | |
| Persona | mount | 1710 | 1712 | 5000 | |
| SpinButton | mount | 1348 | 1372 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 83 | 74 | 1.12:1 |
| AttachmentMinimalPerf.default | 89 | 80 | 1.11:1 |
| LoaderMinimalPerf.default | 192 | 174 | 1.1:1 |
| PortalMinimalPerf.default | 84 | 77 | 1.09:1 |
| SkeletonMinimalPerf.default | 203 | 186 | 1.09:1 |
| TreeWith60ListItems.default | 94 | 86 | 1.09:1 |
| FlexMinimalPerf.default | 159 | 150 | 1.06:1 |
| AvatarMinimalPerf.default | 107 | 102 | 1.05:1 |
| CarouselMinimalPerf.default | 273 | 260 | 1.05:1 |
| ListCommonPerf.default | 388 | 370 | 1.05:1 |
| ProviderMergeThemesPerf.default | 672 | 643 | 1.05:1 |
| VideoMinimalPerf.default | 434 | 414 | 1.05:1 |
| TableMinimalPerf.default | 233 | 224 | 1.04:1 |
| TreeMinimalPerf.default | 470 | 450 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 153 | 149 | 1.03:1 |
| DropdownManyItemsPerf.default | 389 | 378 | 1.03:1 |
| GridMinimalPerf.default | 195 | 189 | 1.03:1 |
| LayoutMinimalPerf.default | 201 | 196 | 1.03:1 |
| RosterPerf.default | 1602 | 1550 | 1.03:1 |
| ProviderMinimalPerf.default | 204 | 198 | 1.03:1 |
| RadioGroupMinimalPerf.default | 267 | 258 | 1.03:1 |
| SegmentMinimalPerf.default | 191 | 186 | 1.03:1 |
| TooltipMinimalPerf.default | 1275 | 1237 | 1.03:1 |
| BoxMinimalPerf.default | 194 | 191 | 1.02:1 |
| DatepickerMinimalPerf.default | 3637 | 3562 | 1.02:1 |
| DialogMinimalPerf.default | 444 | 434 | 1.02:1 |
| HeaderSlotsPerf.default | 465 | 454 | 1.02:1 |
| ListNestedPerf.default | 321 | 314 | 1.02:1 |
| ListWith60ListItems.default | 379 | 371 | 1.02:1 |
| StatusMinimalPerf.default | 395 | 387 | 1.02:1 |
| AttachmentSlotsPerf.default | 640 | 632 | 1.01:1 |
| CheckboxMinimalPerf.default | 1130 | 1121 | 1.01:1 |
| ListMinimalPerf.default | 310 | 307 | 1.01:1 |
| PopupMinimalPerf.default | 357 | 353 | 1.01:1 |
| SliderMinimalPerf.default | 767 | 758 | 1.01:1 |
| CustomToolbarPrototype.default | 1454 | 1442 | 1.01:1 |
| ToolbarMinimalPerf.default | 524 | 521 | 1.01:1 |
| CardMinimalPerf.default | 302 | 301 | 1:1 |
| DropdownMinimalPerf.default | 1404 | 1405 | 1:1 |
| InputMinimalPerf.default | 529 | 527 | 1:1 |
| ItemLayoutMinimalPerf.default | 698 | 700 | 1:1 |
| RefMinimalPerf.default | 106 | 106 | 1:1 |
| AlertMinimalPerf.default | 152 | 154 | 0.99:1 |
| FormMinimalPerf.default | 221 | 223 | 0.99:1 |
| HeaderMinimalPerf.default | 199 | 202 | 0.99:1 |
| MenuButtonMinimalPerf.default | 934 | 948 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2241 | 2255 | 0.99:1 |
| IconMinimalPerf.default | 380 | 382 | 0.99:1 |
| EmbedMinimalPerf.default | 1818 | 1851 | 0.98:1 |
| ImageMinimalPerf.default | 224 | 229 | 0.98:1 |
| LabelMinimalPerf.default | 218 | 222 | 0.98:1 |
| MenuMinimalPerf.default | 492 | 502 | 0.98:1 |
| TextMinimalPerf.default | 192 | 195 | 0.98:1 |
| ButtonOverridesMissPerf.default | 640 | 658 | 0.97:1 |
| ButtonSlotsPerf.default | 315 | 325 | 0.97:1 |
| ChatMinimalPerf.default | 407 | 420 | 0.97:1 |
| ChatWithPopoverPerf.default | 190 | 195 | 0.97:1 |
| TableManyItemsPerf.default | 1076 | 1114 | 0.97:1 |
| TextAreaMinimalPerf.default | 277 | 286 | 0.97:1 |
| DividerMinimalPerf.default | 198 | 206 | 0.96:1 |
| ButtonMinimalPerf.default | 88 | 93 | 0.95:1 |
| AnimationMinimalPerf.default | 277 | 294 | 0.94:1 |
| ReactionMinimalPerf.default | 203 | 215 | 0.94:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 92262e5:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 625 | 639 | 5000 | |
| Breadcrumb | mount | 1658 | 1673 | 1000 | |
| Checkbox | mount | 1666 | 1678 | 5000 | |
| CheckboxBase | mount | 1455 | 1487 | 5000 | |
| ChoiceGroup | mount | 2908 | 2917 | 5000 | |
| ComboBox | mount | 639 | 624 | 1000 | |
| CommandBar | mount | 6141 | 6109 | 1000 | |
| ContextualMenu | mount | 11718 | 11778 | 1000 | |
| DefaultButton | mount | 739 | 735 | 5000 | |
| DetailsRow | mount | 2159 | 2154 | 5000 | |
| DetailsRowFast | mount | 2212 | 2166 | 5000 | |
| DetailsRowNoStyles | mount | 2017 | 2004 | 5000 | |
| Dialog | mount | 2646 | 2642 | 1000 | |
| DocumentCardTitle | mount | 228 | 230 | 1000 | |
| Dropdown | mount | 1985 | 1928 | 5000 | |
| FocusTrapZone | mount | 1123 | 1120 | 5000 | |
| FocusZone | mount | 1045 | 1041 | 5000 | |
| GroupedList | mount | 41242 | 40892 | 2 | |
| GroupedList | virtual-rerender | 19649 | 19592 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 49935 | 50338 | 2 | |
| GroupedListV2 | mount | 223 | 226 | 2 | |
| GroupedListV2 | virtual-rerender | 208 | 207 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 232 | 220 | 2 | |
| IconButton | mount | 1039 | 1075 | 5000 | |
| Label | mount | 335 | 344 | 5000 | |
| Layer | mount | 2696 | 2667 | 5000 | |
| Link | mount | 385 | 394 | 5000 | |
| MenuButton | mount | 917 | 915 | 5000 | |
| MessageBar | mount | 21483 | 21586 | 5000 | |
| Nav | mount | 1935 | 1900 | 1000 | |
| OverflowSet | mount | 772 | 781 | 5000 | |
| Panel | mount | 1747 | 1715 | 1000 | |
| Persona | mount | 741 | 724 | 1000 | |
| Pivot | mount | 857 | 839 | 1000 | |
| PrimaryButton | mount | 817 | 824 | 5000 | |
| Rating | mount | 4526 | 4546 | 5000 | |
| SearchBox | mount | 904 | 915 | 5000 | |
| Shimmer | mount | 1857 | 1857 | 5000 | |
| Slider | mount | 1297 | 1283 | 5000 | |
| SpinButton | mount | 2833 | 2856 | 5000 | |
| Spinner | mount | 391 | 387 | 5000 | |
| SplitButton | mount | 1833 | 1808 | 5000 | |
| Stack | mount | 401 | 390 | 5000 | |
| StackWithIntrinsicChildren | mount | 839 | 854 | 5000 | |
| StackWithTextChildren | mount | 2598 | 2582 | 5000 | |
| SwatchColorPicker | mount | 6045 | 6053 | 5000 | |
| TagPicker | mount | 1478 | 1498 | 5000 | |
| Text | mount | 364 | 380 | 5000 | |
| TextField | mount | 924 | 949 | 5000 | |
| ThemeProvider | mount | 835 | 828 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 584 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1270 | 1257 | 5000 | |
| Toggle | mount | 610 | 606 | 5000 | |
| buttonNative | mount | 188 | 189 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 626775836611bb51ca78425a52de8fc338b8b763 (build) |
sopranopillow
commented
Oct 18, 2023
🕵 fluentuiv8 No visual regressions between this PR and main |
TristanWatanabe
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Can you please share a link to the component epic? Like this one, #29187.
microsoft-github-policy-service
bot
added
Area: Components
Component: InfoButton
labels
Thanks 👍 It seems that the issue is using an outdated template, can you please check and align with the latest template? |
Done! |
JustSlone
reviewed
Oct 19, 2023
khmakoto
reviewed
Oct 19, 2023
packages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelPatternDecision.md
Show resolved
Hide resolved
khmakoto
approved these changes
Oct 19, 2023
JustSlone
approved these changes
Oct 19, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 24, 2023
* master: (48 commits) fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524) feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536) feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597) feat: (breadcrumb) Removed appearance prop (microsoft#29554) chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476) Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395) applying package updates applying package updates chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603) docs: Add guidance for modifying textarea's height. (microsoft#29601) fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611) [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608) chore: bump jest to 29.7.0 (microsoft#29298) applying package updates feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585) feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587) feat: adds motion to DialogSurface (microsoft#29391) fix: Use correct target windows for ResizeObserver (microsoft#29551) chg (microsoft#29592) Fix missing x callout custom callout (microsoft#29547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR releases InfoLabel to stable. It renames the package react-infolabel-preview to react-infolabel and adds InfoLabel to react-components. The command
yarn nx g @fluentui/workspace-plugin:prepare-initial-release --project @fluentui/react-infolabel-preview --phase=stablewas run to achieve this.Related Issue(s)