Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 2] Changes to onboard charting to fluent docsite #29608

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

AtishayMsft
Copy link
Contributor

Previous Behavior

New Behavior

This PR includes the following changes:

  • Updated readme and split more involved technical information into a separate document.
  • Added tags to extract api documentation from interfaces.
  • Improved the examples and added few examples.

Related Issue(s)

Part 1 to onboard charting to fluent docsite: #29210

  • Fixes #

@AtishayMsft AtishayMsft requested a review from a team as a code owner October 20, 2023 10:23
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 0f1b7bb39becda238db0535df32195434265acc5

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbac1a2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9c7c2e07f2153575de077ca03644e4846f9f7d70 (build)

@AtishayMsft AtishayMsft merged commit c8ed0b5 into master Oct 20, 2023
23 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 24, 2023
* master: (48 commits)
  fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524)
  feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536)
  feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597)
  feat: (breadcrumb) Removed appearance prop (microsoft#29554)
  chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476)
  Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395)
  applying package updates
  applying package updates
  chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603)
  docs: Add guidance for modifying textarea's height. (microsoft#29601)
  fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611)
  [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608)
  chore: bump jest to 29.7.0 (microsoft#29298)
  applying package updates
  feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585)
  feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587)
  feat: adds motion to DialogSurface (microsoft#29391)
  fix: Use correct target windows for ResizeObserver (microsoft#29551)
  chg (microsoft#29592)
  Fix missing x callout custom callout (microsoft#29547)
  ...
@khmakoto khmakoto deleted the usr/atisjai/onboardChartingDocsite_1020_2 branch April 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants