WS 2004 supports dual stack #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcantah @katiewasnothere @daschott any ideas if this is correct or if certain patch releases in hns v11 don't support dualstack? |
|
@jsturtevant I'm not sure. Paging @elweb9858 as she's helped me understand the HNS versioning madness before |
|
@kumarvin123 was it intentional that HNS version 11 was not included in the supported versions here ? |
jsturtevant
force-pushed
the
update-ipv6-versioning
branch
from
310d3fd to
0882cf3
Compare
|
Based on some conversations we've identified that WS 2004+ supports dualstack and that corresponds to HNS v11.10+. 10.5 corresponds to 19H2 which doesn't have full support |
elweb9858
approved these changes
Apr 28, 2021
dcantah
approved these changes
Apr 28, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
dcantah
added a commit
to dcantah/kubernetes
that referenced
this pull request
Sep 22, 2021
Due to an incorrect version range definition in hcsshim for dualstack support, the Windows kubeproxy had to define it's own version range logic to check if dualstack was supported on the host. This was remedied in hcsshim (microsoft/hcsshim#1003) and this work has been vendored into K8s as well (kubernetes#104880). This change simply makes use of the now correct version range to check if dualstack is supported, and gets rid of the old custom logic. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
ibabou
pushed a commit
to ibabou/kubernetes
that referenced
this pull request
Sep 28, 2021
Due to an incorrect version range definition in hcsshim for dualstack support, the Windows kubeproxy had to define it's own version range logic to check if dualstack was supported on the host. This was remedied in hcsshim (microsoft/hcsshim#1003) and this work has been vendored into K8s as well (kubernetes#104880). This change simply makes use of the now correct version range to check if dualstack is supported, and gets rid of the old custom logic. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 28, 2024
…ning WS 2004 supports dual stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on kubernetes/kubernetes#101047 I found that WS 2004 is not being shown as support.
Docs state: 2004 (kernel version 10.0.19041.610)
I added custom logging to kubeproxy which showed I was on version
11of HNS on10.0.19041I am not sure how HNS versions map to WS versions. Maybe there are minor versions of 2004 that don't support it?