Move around HCS schema and resource path definitions #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a good opportunity to prepare for clearer package organization in the future. These resource paths are all specific to the HCS/GCS schema and protocol, so I would like the package structure to reflect that. Maybe a structure like: Thoughts? |
That looks great to me. I went back and forth on whether to add these to schema2 but those should ideally stay entirely generated. I'm in favor. |
As both the V1 and V2 HCS schema are tied to HCS itself, it makes more sense to have the schema definitions co-located under the hcs package. The resource paths are also tied to HCS and in preparation of some work where we'll need the resourcepaths available outside of the uvm and gcs packages, move the resource paths for both virtual machines and containers to their own package. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
changed the title
|
@kevpar Done |
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jul 14, 2021
This was left behind due to an unlucky conflict between microsoft#1004 and microsoft#930. The file already existed with the same content at the new location, and nothing was referencing this location, so a trivial deletion. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This was left behind due to an unlucky conflict between microsoft#1004 and microsoft#930. The file already existed with the same content at the new location, and nothing was referencing this location, so a trivial deletion. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As both the V1 and V2 HCS schema are tied to HCS itself, it makes more sense to have the schema definitions co-located under the hcs package. The resource paths are also tied to HCS and in preparation of some work where we'll need the resourcepaths available outside of the uvm and gcs packages, move the resource paths for both virtual machines and containers to their own package.
Signed-off-by: Daniel Canter dcanter@microsoft.com