Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export annotations for use in test suite #1061

Merged

Conversation

katiewasnothere
Copy link
Contributor

The goal of this PR is to reduce the chances of outdated/wrong tests if an annotation is changed or removed

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner July 7, 2021 01:13
@dcantah
Copy link
Contributor

dcantah commented Jul 7, 2021

I didn't know I wanted this until now 😆

@dcantah
Copy link
Contributor

dcantah commented Jul 7, 2021

You'll have to re-vendor hcsshim into.. hcsshim (never gets old) to get the tests passing I imagine.

Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things of feedback on the comments but lgtm, thanks again 🙂

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants