Support registering and unregistering ncproxy as a Windows service #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
reviewed
Jun 24, 2021
|
@anmaxvl @katiewasnothere ptal when you get a chance again. |
kevpar
reviewed
Jun 25, 2021
kevpar
reviewed
Jun 25, 2021
kevpar
reviewed
Jun 25, 2021
kevpar
reviewed
Jun 25, 2021
cmd/ncproxy/run.go
Outdated
| *logDir = filepath.Dir(binLocation) | ||
| } else { | ||
| // If a log dir was provided, make sure it exists. | ||
| if _, err := os.Stat(*logDir); os.IsNotExist(err) { |
There was a problem hiding this comment.
should we return errors that aren't os.IsNotExist?
There was a problem hiding this comment.
I guess we should just check err != nil as mkdirall will just return nil if the directory already exists.
katiewasnothere
approved these changes
Jul 1, 2021
|
@katiewasnothere Thanks! |
dcantah
force-pushed
the
ncproxy-service
branch
2 times, most recently
from
955a6ed to
ad95e18
Compare
katiewasnothere
approved these changes
Jul 2, 2021
anmaxvl
approved these changes
Jul 7, 2021
Borrowed heavily from the Containerd implementation: https://github.com/containerd/containerd/blob/master/cmd/containerd/command/service_windows.go Go mod vendor to bring in the x/sys/windows/svc package Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
Push was squashing the pr feedback commits |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed heavily from the Containerd implementation:
https://github.com/containerd/containerd/blob/master/cmd/containerd/command/service_windows.go
Go mod vendor to bring in the x/sys/windows/svc package
Signed-off-by: Daniel Canter dcanter@microsoft.com