Add syscallWatcher for some missing syscalls #388
Conversation
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
jterry75
force-pushed
the
syscall_watcher
branch
from
071c3d1 to
76e0b39
Compare
|
It was deliberate to not put these around (especially) Resize as Docker CLI triggers this IIRC every 200ms, during an interactive session due to lack of equivalence to SIGWINCH. This will end up building a huge number of goroutines in any caller, so I would definitely not include this one. Perhaps a comment as to why would be relevant. To the best of my knowledge, I don't think I've seen any of the others ever hang, perhaps with the exception of CloseStdin. |
|
On a side note, I believe in recent versions of Windows 10, the console does send window size change events on request. So we could probably fix the Docker client at this point. |
|
I can remove it from Resize but it seems to me that this could hang anywhere so why would we special case any syscalls? |
|
@jhowardmsft - Its your call here. I can close this PR if we think none of these are helpful or if they are too verbose. Seems like your concern could also be alleviated by a |
|
I'd prefer to close this PR for now, until something like your suggestion of a cancellation could be implemented (which is a really good thing to add regardless) |
|
Ok np |
Add a new generic hook for use in device setup
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
Signed-off-by: Justin Terry (VM) juterry@microsoft.com