-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for security policy enforcement #1325
Add tests for security policy enforcement #1325
Conversation
cc2bd61
to
1c2ea78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree with Amit that configOpt
and co should be part of securitypolicy
. But otherwise, LGTM
17307b5
to
29f6c8f
Compare
Linters failing as some of the go tooling didn't have support for 1.18, and ^1.17.0 is resolving to 1.18 now in our CI. golangci/golangci-lint#2438 |
Add basic positive and negative tests for security policy enforcement. Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
29f6c8f
to
77e0f86
Compare
Add basic positive and negative tests for security policy enforcement.
Signed-off-by: Maksim An maksiman@microsoft.com