Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix working_dir negative test error expectation #1348

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Apr 9, 2022

Signed-off-by: Maksim An maksiman@microsoft.com

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner April 9, 2022 07:06
@anmaxvl anmaxvl merged commit 2028de8 into microsoft:master Apr 10, 2022
@anmaxvl anmaxvl deleted the tests/fix-wrong-error-expectation branch April 10, 2022 22:10
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Apr 19, 2022
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Apr 22, 2022
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Apr 22, 2022
…)"

This reverts commit 2028de8.

Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Apr 22, 2022
…)"

This reverts commit 2028de8.

During local testing a gcs with an older version of security policy
was used when doing the fix: microsoft#1322. As we can see, the quotations
weren't there. However, later a PR was merged, which added them: microsoft#1311

Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl added a commit that referenced this pull request Apr 22, 2022
This reverts commit 2028de8.

During local testing a gcs with an older version of security policy
was used when doing the fix: #1322. As we can see, the quotations
weren't there. However, later a PR was merged, which added them: #1311

Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
anmaxvl added a commit that referenced this pull request Feb 7, 2023
Sync ADO with upstream to enable including test GCS binaries as
part of dev-pipeline

Related work items: #1311, #1322, #1341, #1343, #1345, #1347, #1348, #1350, #1353, #1354, #1355, #1358, #1361, #1365, #1368, #1369, #1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants