This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Add trace magic command #209
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
cgranade
reviewed
Jul 14, 2020
05dd758
to
68d2c44
Compare
rmshaffer
reviewed
Jul 15, 2020
434fd3f
to
ec8a53e
Compare
1d7115c
to
948c986
Compare
ae9e2e3
to
5096ba3
Compare
ed6ad70
to
e4435cb
Compare
rmshaffer
previously approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And thanks for adding the tests as well, very nice. One tiny suggestion - perhaps rename the PR before merging to reflect the new magic command name?
1b36afc
to
97804b2
Compare
Changed the base branch due to a GIthub bug when the base branch changed from |
rmshaffer
approved these changes
Jul 17, 2020
theRoughCode
added a commit
that referenced
this pull request
Jul 25, 2020
* Add view magic command * Rename ExecutionPathEncoder to DisplayableHtmlEncoder * Add documentation to view command * Rename %view to %trace * Fix JSON parsing * Add TraceMagic test * Add flag for depth * Fix nested test * Empty commit to trigger CI * Empty commit to trigger CI
theRoughCode
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Add path visualizer JS files (#201) * Add JS tests for ExecutionPathVisualizer (#205) * Add test for operations with no qubits (#217) * Add `ExecutionPathTracer` to repo. (#195) * Add ExecutionPathTracer to repo * Add WithExecutionPathTracer extension method to SimulatorBase * Respond to PR feedback * Use GetRuntimeMetadata * Remove ApplyToEach * Add tests * Use Newtonsoft instead of System.Text.Json * Rename ArgStr to DisplayArgs * Clean up code * Fix typo in tsconfig * Fix tests * Add trace magic command (#209) * Add view magic command * Rename ExecutionPathEncoder to DisplayableHtmlEncoder * Add documentation to view command * Rename %view to %trace * Fix JSON parsing * Add TraceMagic test * Add flag for depth * Fix nested test * Empty commit to trigger CI * Empty commit to trigger CI * Wrap DisplayArgs in parentheses (#225) * Change depth flag to --depth * Add parentheses around DisplayArgs if it doesn't have it * Trigger CI rebuild * Fix depth bug and render all ops at or above desired depth (#226) * Bump qsharp-runtime version and add tests for operations as args (#227) * Add tests for operations with operations as arguments * Build 0.12.2007.2301. Co-authored-by: Project Collection Build Service (ms-quantum) <> * Implement `IsMeasurement` flag for execution path operations (#230) * Implement isMeasurement flag for execution path operations * Rename 'controlled' and 'adjoint' to 'isControlled' and 'isAdjoint' * Allow default depth for %trace to be set in %config (#229) * Allow default depth for %trace to be set in %config * Fix config magic description * Add composite operation handling (#219) * Add composite operation handling * Add ForEach tests * Add Canon.qs to Tests.IQSharp.csproj * Build 0.12.2007.2412. * Fix ResetAll tests * Fix tests to allow using Microsoft.Quantum.Canon * Add newline * Build 0.12.2007.3008. * Reformat ExecutionPathTracer stylistically * Fix iqsharp.sln * Empty commit to retrigger CI * Remove dotnet test args * Fix broken build * Fix TraceMagic test * Fix broken build tests Co-authored-by: Project Collection Build Service (ms-quantum) <> * Add syntax highlighting for %trace and %lsopen commands (#240) * Add syntax highlighting for %trace command * Fix ordering and add lsopen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the last out of 3 components (Simulator, JavaScript renderer, magic command) required to implement #158 .
This PR adds the
%trace
magic command required to render the execution path within IQ#.This will be merged in to the feature branch (
feature/path_visualizer
).Example screenshot of magic command:
