Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

theRoughCode
Copy link
Contributor

@theRoughCode theRoughCode commented Jul 14, 2020

This PR addresses the last out of 3 components (Simulator, JavaScript renderer, magic command) required to implement #158 .

This PR adds the %trace magic command required to render the execution path within IQ#.

This will be merged in to the feature branch (feature/path_visualizer).

Example screenshot of magic command:
image

@theRoughCode theRoughCode force-pushed the raphael/tracer branch 2 times, most recently from 434fd3f to ec8a53e Compare July 16, 2020 00:41
@theRoughCode theRoughCode marked this pull request as ready for review July 17, 2020 04:26
Base automatically changed from raphael/tracer to feature/path_visualizer July 17, 2020 15:04
rmshaffer
rmshaffer previously approved these changes Jul 17, 2020
Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And thanks for adding the tests as well, very nice. One tiny suggestion - perhaps rename the PR before merging to reflect the new magic command name?

@theRoughCode theRoughCode changed the title Add view magic command Add trace magic command Jul 17, 2020
@theRoughCode theRoughCode changed the base branch from feature/path_visualizer to master July 17, 2020 15:34
@theRoughCode theRoughCode dismissed rmshaffer’s stale review July 17, 2020 15:34

The base branch was changed.

@theRoughCode theRoughCode changed the base branch from master to feature/path_visualizer July 17, 2020 15:35
@theRoughCode
Copy link
Contributor Author

Changed the base branch due to a GIthub bug when the base branch changed from raphael/tracer to feature/path_visualizer.

@theRoughCode theRoughCode merged commit 22aa13d into feature/path_visualizer Jul 17, 2020
theRoughCode added a commit that referenced this pull request Jul 25, 2020
* Add view magic command

* Rename ExecutionPathEncoder to DisplayableHtmlEncoder

* Add documentation to view command

* Rename %view to %trace

* Fix JSON parsing

* Add TraceMagic test

* Add flag for depth

* Fix nested test

* Empty commit to trigger CI

* Empty commit to trigger CI
theRoughCode pushed a commit that referenced this pull request Jul 31, 2020
* Add path visualizer JS files (#201)

* Add JS tests for ExecutionPathVisualizer (#205)

* Add test for operations with no qubits (#217)

* Add `ExecutionPathTracer` to repo. (#195)

* Add ExecutionPathTracer to repo

* Add WithExecutionPathTracer extension method to SimulatorBase

* Respond to PR feedback

* Use GetRuntimeMetadata

* Remove ApplyToEach

* Add tests

* Use Newtonsoft instead of System.Text.Json

* Rename ArgStr to DisplayArgs

* Clean up code

* Fix typo in tsconfig

* Fix tests

* Add trace magic command (#209)

* Add view magic command

* Rename ExecutionPathEncoder to DisplayableHtmlEncoder

* Add documentation to view command

* Rename %view to %trace

* Fix JSON parsing

* Add TraceMagic test

* Add flag for depth

* Fix nested test

* Empty commit to trigger CI

* Empty commit to trigger CI

* Wrap DisplayArgs in parentheses (#225)

* Change depth flag to --depth

* Add parentheses around DisplayArgs if it doesn't have it

* Trigger CI rebuild

* Fix depth bug and render all ops at or above desired depth (#226)

* Bump qsharp-runtime version and add tests for operations as args (#227)

* Add tests for operations with operations as arguments

* Build 0.12.2007.2301.

Co-authored-by: Project Collection Build Service (ms-quantum) <>

* Implement `IsMeasurement` flag for execution path operations (#230)

* Implement isMeasurement flag for execution path operations

* Rename 'controlled' and 'adjoint' to 'isControlled' and 'isAdjoint'

* Allow default depth for %trace to be set in %config (#229)

* Allow default depth for %trace to be set in %config

* Fix config magic description

* Add composite operation handling (#219)

* Add composite operation handling

* Add ForEach tests

* Add Canon.qs to Tests.IQSharp.csproj

* Build 0.12.2007.2412.

* Fix ResetAll tests

* Fix tests to allow using Microsoft.Quantum.Canon

* Add newline

* Build 0.12.2007.3008.

* Reformat ExecutionPathTracer stylistically

* Fix iqsharp.sln

* Empty commit to retrigger CI

* Remove dotnet test args

* Fix broken build

* Fix TraceMagic test

* Fix broken build tests

Co-authored-by: Project Collection Build Service (ms-quantum) <>

* Add syntax highlighting for %trace and %lsopen commands (#240)

* Add syntax highlighting for %trace command

* Fix ordering and add lsopen
@theRoughCode theRoughCode deleted the raphael/view_magic branch August 5, 2020 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants