This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Add composite operation handling #219
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c93ed94
to
217dc93
Compare
anpaz
approved these changes
Jul 24, 2020
fe0063f
to
189e99b
Compare
add8675
to
64fdbd2
Compare
189e99b
to
10d4ec2
Compare
78755f2
to
4a20a96
Compare
4a20a96
to
f413c71
Compare
rmshaffer
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks for working through the issues with testing the downstream library functionality! I left only a couple of purely stylistic comments, feel free to address or ignore as you prefer.
theRoughCode
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Add path visualizer JS files (#201) * Add JS tests for ExecutionPathVisualizer (#205) * Add test for operations with no qubits (#217) * Add `ExecutionPathTracer` to repo. (#195) * Add ExecutionPathTracer to repo * Add WithExecutionPathTracer extension method to SimulatorBase * Respond to PR feedback * Use GetRuntimeMetadata * Remove ApplyToEach * Add tests * Use Newtonsoft instead of System.Text.Json * Rename ArgStr to DisplayArgs * Clean up code * Fix typo in tsconfig * Fix tests * Add trace magic command (#209) * Add view magic command * Rename ExecutionPathEncoder to DisplayableHtmlEncoder * Add documentation to view command * Rename %view to %trace * Fix JSON parsing * Add TraceMagic test * Add flag for depth * Fix nested test * Empty commit to trigger CI * Empty commit to trigger CI * Wrap DisplayArgs in parentheses (#225) * Change depth flag to --depth * Add parentheses around DisplayArgs if it doesn't have it * Trigger CI rebuild * Fix depth bug and render all ops at or above desired depth (#226) * Bump qsharp-runtime version and add tests for operations as args (#227) * Add tests for operations with operations as arguments * Build 0.12.2007.2301. Co-authored-by: Project Collection Build Service (ms-quantum) <> * Implement `IsMeasurement` flag for execution path operations (#230) * Implement isMeasurement flag for execution path operations * Rename 'controlled' and 'adjoint' to 'isControlled' and 'isAdjoint' * Allow default depth for %trace to be set in %config (#229) * Allow default depth for %trace to be set in %config * Fix config magic description * Add composite operation handling (#219) * Add composite operation handling * Add ForEach tests * Add Canon.qs to Tests.IQSharp.csproj * Build 0.12.2007.2412. * Fix ResetAll tests * Fix tests to allow using Microsoft.Quantum.Canon * Add newline * Build 0.12.2007.3008. * Reformat ExecutionPathTracer stylistically * Fix iqsharp.sln * Empty commit to retrigger CI * Remove dotnet test args * Fix broken build * Fix TraceMagic test * Fix broken build tests Co-authored-by: Project Collection Build Service (ms-quantum) <> * Add syntax highlighting for %trace and %lsopen commands (#240) * Add syntax highlighting for %trace command * Fix ordering and add lsopen
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling for composite operations like
ApplyToEach
.Basically, when we see
ApplyToEach(H, qs)
, we renderH(q[0])...H(q[N])
individually instead. The way we do this is by setting the flagIsComposite=true
for composite operations. In this PR, we check for that flag and recursively get the execution paths of each of its nested children operations.This PR also adds a
Mock.Standard
library that includes mocked out versions ofApplyToEach
andForEach
which are required in the new tests in this PR. BothMock.Standard
andMock.Chemistry
are moved under the folderMockLibraries
.