Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

theRoughCode
Copy link
Contributor

@theRoughCode theRoughCode commented Jul 17, 2020

Add handling for composite operations like ApplyToEach.

Basically, when we see ApplyToEach(H, qs), we render H(q[0])...H(q[N]) individually instead. The way we do this is by setting the flag IsComposite=true for composite operations. In this PR, we check for that flag and recursively get the execution paths of each of its nested children operations.

This PR also adds a Mock.Standard library that includes mocked out versions of ApplyToEach and ForEach which are required in the new tests in this PR. Both Mock.Standard and Mock.Chemistry are moved under the folder MockLibraries.

@theRoughCode theRoughCode self-assigned this Jul 17, 2020
@theRoughCode theRoughCode marked this pull request as draft July 17, 2020 20:15
Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks for working through the issues with testing the downstream library functionality! I left only a couple of purely stylistic comments, feel free to address or ignore as you prefer.

@theRoughCode theRoughCode merged commit 4d954e5 into feature/path_visualizer Jul 31, 2020
@theRoughCode theRoughCode deleted the raphael/composite branch July 31, 2020 15:52
theRoughCode pushed a commit that referenced this pull request Jul 31, 2020
* Add path visualizer JS files (#201)

* Add JS tests for ExecutionPathVisualizer (#205)

* Add test for operations with no qubits (#217)

* Add `ExecutionPathTracer` to repo. (#195)

* Add ExecutionPathTracer to repo

* Add WithExecutionPathTracer extension method to SimulatorBase

* Respond to PR feedback

* Use GetRuntimeMetadata

* Remove ApplyToEach

* Add tests

* Use Newtonsoft instead of System.Text.Json

* Rename ArgStr to DisplayArgs

* Clean up code

* Fix typo in tsconfig

* Fix tests

* Add trace magic command (#209)

* Add view magic command

* Rename ExecutionPathEncoder to DisplayableHtmlEncoder

* Add documentation to view command

* Rename %view to %trace

* Fix JSON parsing

* Add TraceMagic test

* Add flag for depth

* Fix nested test

* Empty commit to trigger CI

* Empty commit to trigger CI

* Wrap DisplayArgs in parentheses (#225)

* Change depth flag to --depth

* Add parentheses around DisplayArgs if it doesn't have it

* Trigger CI rebuild

* Fix depth bug and render all ops at or above desired depth (#226)

* Bump qsharp-runtime version and add tests for operations as args (#227)

* Add tests for operations with operations as arguments

* Build 0.12.2007.2301.

Co-authored-by: Project Collection Build Service (ms-quantum) <>

* Implement `IsMeasurement` flag for execution path operations (#230)

* Implement isMeasurement flag for execution path operations

* Rename 'controlled' and 'adjoint' to 'isControlled' and 'isAdjoint'

* Allow default depth for %trace to be set in %config (#229)

* Allow default depth for %trace to be set in %config

* Fix config magic description

* Add composite operation handling (#219)

* Add composite operation handling

* Add ForEach tests

* Add Canon.qs to Tests.IQSharp.csproj

* Build 0.12.2007.2412.

* Fix ResetAll tests

* Fix tests to allow using Microsoft.Quantum.Canon

* Add newline

* Build 0.12.2007.3008.

* Reformat ExecutionPathTracer stylistically

* Fix iqsharp.sln

* Empty commit to retrigger CI

* Remove dotnet test args

* Fix broken build

* Fix TraceMagic test

* Fix broken build tests

Co-authored-by: Project Collection Build Service (ms-quantum) <>

* Add syntax highlighting for %trace and %lsopen commands (#240)

* Add syntax highlighting for %trace command

* Fix ordering and add lsopen
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants