Dev to Master - 5.4.0-preview #853

yitam · 2018-09-24T19:02:46Z

No description provided.

Dev

Fixed the potential error reported by Prefast code analysis

Use SQLSRV_ASSERT for checking NULL ptrs

For these AKV tests check env despite not AE connected

Added the driver option to run functional tests

Fixed connection pooling tests for more than one ODBC drivers

* Added the driver argument to getDSN * Dropped the driver argument but set to null as default * Removed the AE condition in locale support * Modified the AE condition for locale support

* Version 5.3.0 * Fixed the wrong replacements * Added comments block to m4 files * Use dnl for comments

… loop through php types (#801) * Modified AE fetch phptypes test to insert only one row at a time and loop through php types * Fixed formatting

* Streamlined two very similar large column name tests * Changed the EOL

* Updates to change log and readme * Dropped support for Ubuntu 17 * Modified as per review comments

… 17.2

* Updated instructions and sample test for 5.3.0 RTW * Fixed sample code to adhere to php coding standard * Fixed cases and spaces * Modified NOTE for UB 18.04 based on review comments * Added 'exit' * Modified change log and readme based on review to PR 811 * Applied review comments

Odbc 172 update for connres and appveyor

* Streamlined two very similar large column name tests * Added random number of test table names to avoid operand clash issues * Replaced to with for based on review

* Changes made to support php 7.3 * Correct use of the smart pointer * Fixed the tests for 7.3 * Some clean up for array_init() * Fixed formattings and clean up

Skipif fix

String initialisation to nulls

Fix for compilation problem

Fix for compilation problem again

) * Issue 434 - set dbh driver data to NULL as well in destructor * Reverted the last change but instead check if dbh driver_data is already freed * Modified the comment

* Made error handling more flexible * Fixed a minor issue with a test

* Incorporated changes in PR 634 to pdo_sqlsrv * Reverted the changes because the array is for internal use only

* Modified README re user's suggestion * Moved the if condition to the end as per review

* Adding supporting for Azure AD access token * Added more comments for the AD access token skipif files * Save the pointer to access token struct until after connecting * Clear the access token data before freeing the memory * Added a reference as per review

…pdo_sqlsrv to return datetime as objects (#842) * Feature request - issue 648 * Fixed constructor for field_cache and added another test * Added tests for FETCH_BOUND * Added a new test for output param * Modified output param test to set attributes differently * Removed a useless helped function in a test * Combined two new tests into one as per review * Uncommented dropTable

…for sqlsrv (#844) * Added ReturnDatesAsStrings option to the statement level * Added new tests for ReturnDatesAsStrings at statement level * Added more datetime types as per review

* Updated version 5.4.0-preview * Replaced 5.3 with 5.4

#849)

* Updated change log for 5.4.0-preview * Updated 5.4.0 preview to add two new feature requests * Modified change log as per review * Modified the wordings * Updated readme, changelog, and install instructions

coveralls · 2018-09-24T19:31:40Z

Coverage increased (+0.3%) to 75.411% when pulling ff3c6a4 on yitam:master into 9654020 on Microsoft:master.

codecov-io · 2018-09-24T19:56:19Z

Codecov Report

Merging #853 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   80.06%   80.18%   +0.11%     
==========================================
  Files          25       25              
  Lines        7325     7419      +94     
==========================================
+ Hits         5865     5949      +84     
- Misses       1460     1470      +10

Impacted Files	Coverage Δ
...-7.1.20-src/ext/pdo_sqlsrv/shared/core_results.cpp
...phpdev/vc14/x86/php-7.1.20-src/ext/sqlsrv/stmt.cpp
...php-7.1.20-src/ext/pdo_sqlsrv/shared/core_stmt.cpp
...x86/php-7.1.20-src/ext/sqlsrv/shared/core_init.cpp
...phpdev/vc14/x86/php-7.1.20-src/ext/sqlsrv/conn.cpp
...php-7.1.20-src/ext/pdo_sqlsrv/shared/core_conn.cpp
...phpdev/vc14/x86/php-7.1.20-src/ext/sqlsrv/init.cpp
...c14/x86/php-7.1.20-src/ext/pdo_sqlsrv/pdo_util.cpp
...ev/vc14/x86/php-7.1.20-src/ext/sqlsrv/php_sqlsrv.h
.../php-7.1.20-src/ext/sqlsrv/shared/core_results.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9654020...ff3c6a4. Read the comment docs.

david-puglielli and others added 30 commits March 31, 2017 18:01

Merge pull request #1 from Microsoft/dev

16c41e0

Dev

Fixed the potential error reported by Prefast code analysis

10ff344

Merge pull request #788 from yitam/fillLastID

3585bf5

Fixed the potential error reported by Prefast code analysis

Use SQLSRV_ASSERT for checking NULL ptrs

44d1bb3

Merge pull request #789 from yitam/moreAsserts

5a66610

Use SQLSRV_ASSERT for checking NULL ptrs

For these AKV tests check env despite not AE connected

f6e450b

Merge pull request #791 from yitam/fixODBC13tests

90c6443

For these AKV tests check env despite not AE connected

Added the driver option to run functional tests

071e897

Merge pull request #793 from yitam/addDriverOption

ea6381c

Added the driver option to run functional tests

Fixed connection pooling tests for more than one ODBC drivers

17fa64a

added driver option to pdo isPooled.php

d554492

Merge pull request #796 from yitam/connPooltests

53e4da4

Fixed connection pooling tests for more than one ODBC drivers

Removed win32 ifdefs re connection resiliency (#802)

81ff085

Set the driver argument for getDSN to null by default (#798)

eeea787

* Added the driver argument to getDSN * Dropped the driver argument but set to null as default * Removed the AE condition in locale support * Modified the AE condition for locale support

Changed int to SQLLEN to avoid infinite loop (#806)

ae0b95b

Version 5.3.0 (#803)

197489a

* Version 5.3.0 * Fixed the wrong replacements * Added comments block to m4 files * Use dnl for comments

Modified AE fetch phptypes test to insert only one row at a time and…

aef3830

… loop through php types (#801) * Modified AE fetch phptypes test to insert only one row at a time and loop through php types * Fixed formatting

Streamlined two very similar large column name tests (#807)

5aa9be7

* Streamlined two very similar large column name tests * Changed the EOL

Updates to change log and readme (#811)

bbfe6df

* Updates to change log and readme * Dropped support for Ubuntu 17 * Modified as per review comments

Fixed connection resiliency tests for Unix, updated AppVeyor for ODBC…

af9f77e

… 17.2

Fixed expected output

b2f7b20

Fixed output and skipifs

82be814

Fixed skipifs and output

0495513

Fixed driver name

c1d5793

build output to debug appveyor failure

a18a59b

removed debug output

cb78977

Merge pull request #814 from david-puglielli/odbc-172-update

9479d03

Odbc 172 update for connres and appveyor

Streamlined two very similar large column name tests (#815)

35631cf

* Streamlined two very similar large column name tests * Added random number of test table names to avoid operand clash issues * Replaced to with for based on review

Changelog updated

706c526

yitam and others added 25 commits July 26, 2018 15:21

Changes made to source and tests to support PHP 7.3 (#822)

b6d815b

* Changes made to support php 7.3 * Correct use of the smart pointer * Fixed the tests for 7.3 * Some clean up for array_init() * Fixed formattings and clean up

One more fix

7357a16

Merge pull request #821 from david-puglielli/skipif-fix

c533ffa

Skipif fix

Initialising strings with nulls

adf86f1

Removed some spaces

a664a5f

Made array index spacing consistent

41a7caf

Merge pull request #825 from david-puglielli/string-initialisation-nulls

026c5d1

String initialisation to nulls

Fix for compilation problem

29f4ad7

Merge pull request #826 from david-puglielli/string-initialisation-nulls

d699680

Fix for compilation problem

Fix for compilation problem again

0b15997

Merge pull request #827 from david-puglielli/string-initialisation-nulls

ba9579b

Fix for compilation problem again

Before freeing stmt in destructor check if dbh driver data is NULL (#829

909d1fa

) * Issue 434 - set dbh driver data to NULL as well in destructor * Reverted the last change but instead check if dbh driver_data is already freed * Modified the comment

Added driver to the skipif conditions (#831)

28a7860

Used git clone instead to download source from a branch of a tag (#832)

4452a4d

Modified the error handling to make it more flexible (#833)

6a688b3

* Made error handling more flexible * Fixed a minor issue with a test

Enabled Spectre Mitigations (#836)

c209b72

Incorporated changes in PR 634 to pdo_sqlsrv (#834)

084ab72

* Incorporated changes in PR 634 to pdo_sqlsrv * Reverted the changes because the array is for internal use only

Modified README re user's suggestion (#841)

ae1b413

* Modified README re user's suggestion * Moved the if condition to the end as per review

Feature request - add ReturnDatesAsStrings option to statement level …

902a032

…for sqlsrv (#844) * Added ReturnDatesAsStrings option to the statement level * Added new tests for ReturnDatesAsStrings at statement level * Added more datetime types as per review

Updated version 5.4.0-preview (#846)

88dfea3

* Updated version 5.4.0-preview * Replaced 5.3 with 5.4

Fixed sqlsrv datetime tests to connect with ColumnEncryption variables (

0ba11a2

#849)

Change log for 5.4.0-preview (#850)

432901d

* Updated change log for 5.4.0-preview * Updated 5.4.0 preview to add two new feature requests * Modified change log as per review * Modified the wordings * Updated readme, changelog, and install instructions

Merge branch 'master' into dev

ff3c6a4

yitam requested a review from david-puglielli September 24, 2018 19:57

david-puglielli approved these changes Sep 24, 2018

View reviewed changes

yitam merged commit b47cec2 into microsoft:master Sep 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev to Master - 5.4.0-preview #853

Dev to Master - 5.4.0-preview #853

yitam commented Sep 24, 2018

coveralls commented Sep 24, 2018

codecov-io commented Sep 24, 2018 •

edited

Loading

Dev to Master - 5.4.0-preview #853

Dev to Master - 5.4.0-preview #853

Conversation

yitam commented Sep 24, 2018

coveralls commented Sep 24, 2018

codecov-io commented Sep 24, 2018 • edited Loading

Codecov Report

codecov-io commented Sep 24, 2018 •

edited

Loading