Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mount Removal] Delete Scalar.Mount.* projects #132

Closed
wilbaker opened this issue Sep 30, 2019 · 4 comments · Fixed by #222
Closed

[Mount Removal] Delete Scalar.Mount.* projects #132

wilbaker opened this issue Sep 30, 2019 · 4 comments · Fixed by #222
Labels
cleanup
Milestone
MVP

Comments

@wilbaker
Copy link
Member

Once the reliance on the mount process is removed, we should stop building/shipping/installing the mount process.
@derrickstolee derrickstolee mentioned this issue Oct 3, 2019
Merged
@derrickstolee
Copy link
Contributor

Should this be paired with deleting the Scalar.Mount.[Mac|Windows] projects from the source code? Perhaps this issue should be renamed to

[Mount Removal] Delete Scalar.Mount.* projects

with the implicit subtask of modifying the installer?

@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
derrickstolee added a commit that referenced this issue Oct 4, 2019
@derrickstolee
Merge pull request #122: Use GVFS Helper transport instead of read ob…
a8b0b08 
…ject hook

See microsoft/git#191 for the Git code regarding the GVFS transport layer. This can work in tandem with the read-object hook, but it _should_ make the read-object hook irrelevant.

* Delete all references to the read-object hook in the product code. This unblocks #4 and the [Mount Removal] tasks #15,  #132, #133, #135, #136, and possible others.

* Delete the Sparse Verb in favor of `git sparse-checkout set`.

* Delete the `BlobPrefetcher` and all references to `--files` or `--folders` prefetching.

Resolves #6, #7, #36.
@wilbaker
Copy link
Member Author

wilbaker commented Oct 4, 2019

Should this be paired with deleting the Scalar.Mount.[Mac|Windows] projects from the source code? Perhaps this issue should be renamed to

[Mount Removal] Delete Scalar.Mount.* projects

with the implicit subtask of modifying the installer?

That sounds good to me, I don't think we have a separate issue for that right now and so I can update this one.

@wilbaker
Copy link
Member Author

wilbaker commented Oct 4, 2019

I don't think we have a separate issue for that right now and so I can update this one.

And I see that I missed that you suggested renaming this one 😄 , sounds good to me!

@wilbaker wilbaker changed the title [Mount Removal] Update the installer to stop installing the mount process [Mount Removal] Delete Scalar.Mount.* projects Oct 4, 2019
This was referenced Oct 21, 2019
Closed
Merged
@github-actions
Copy link

github-actions bot commented Nov 3, 2019

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Nov 3, 2019
@jrbriggs jrbriggs removed the no-activity Stale issue or PR that will be automatically closed soon. label Nov 3, 2019
@wilbaker wilbaker mentioned this issue Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

scalar: Remove Scalar.Mount wilbaker/gsd
3 participants
@derrickstolee @jrbriggs @wilbaker