Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mount Removal] Remove disk layout upgrade code #15

Closed
derrickstolee opened this issue Aug 8, 2019 · 9 comments · Fixed by #203
Closed

[Mount Removal] Remove disk layout upgrade code #15

derrickstolee opened this issue Aug 8, 2019 · 9 comments · Fixed by #203
Assignees
@wilbaker
Labels
disk-layout Issues that impact the disk layout used by Scalar engineering
Milestone
MVP

Comments

@derrickstolee
Copy link
Contributor

derrickstolee commented Aug 8, 2019 •
edited by wilbaker
Loading

UPDATE

The upgrade steps are run as part of scalar mount will will be going away as part of the mount removal process.

We should remove the upgrade code as part of removing the mount process, and if in the future we need to perform disk layout upgrades it will need to be driving by the service and/or the installer.

We no longer need back-compat logic for previous GVFS disk layouts. We will dramatically change the way we store the repo config, and hopefully do so before we ship to EA.

At some point, we will not allow breaking changes and then will need upgrade logic. Should we delete the disk layout code now and then redesign/reimplement the upgrade logic when we need it?

cc: @mjcheetham
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Aug 16, 2019
@derrickstolee derrickstolee added engineering and removed no-activity Stale issue or PR that will be automatically closed soon. labels Aug 16, 2019
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Aug 17, 2019
@jrbriggs jrbriggs removed the no-activity Stale issue or PR that will be automatically closed soon. label Aug 17, 2019
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Aug 19, 2019
@jrbriggs jrbriggs removed the no-activity Stale issue or PR that will be automatically closed soon. label Aug 19, 2019
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Sep 18, 2019
@derrickstolee
Copy link
Contributor Author

Closing for now. May reopen if necessary.

@wilbaker
Copy link
Member

Closing for now. May reopen if necessary.

@derrickstolee the upgrade steps are only run during the mount command, and so I suspect the upgraders will be removed as a natural part of eliminating the mount process (and mount verb).

@derrickstolee
Copy link
Contributor Author

Closing for now. May reopen if necessary.

@derrickstolee the upgrade steps are only run during the mount command, and so I suspect the upgraders will be removed as a natural part of eliminating the mount process (and mount verb).

@wilbaker Happy to hear that this work will piggy-back nicely into other pressing work. Do you want to leave this to be naturally gathered as part of that work, or do you want to reopen this issue and add [MOUNT REMOVAL] to the title?

@wilbaker
Copy link
Member

Do you want to leave this to be naturally gathered as part of that work, or do you want to reopen this issue and add [MOUNT REMOVAL] to the title?

I will re-open this with [MOUNT REMOVAL] in the title. Assuming we remove dead code as we go there shouldn't be any extra work required for this issue, but we can leave it open as a reminder to perform the cleanup work.

@wilbaker wilbaker changed the title Consider deleting disk layout upgrades [Mount Removal] Remove disk layout upgrade code Sep 18, 2019
@wilbaker
Copy link
Member

@derrickstolee I've re-opened the issue and added more details to the description, thanks!

@wilbaker wilbaker reopened this Sep 18, 2019
@wilbaker wilbaker removed the no-activity Stale issue or PR that will be automatically closed soon. label Sep 23, 2019
@wilbaker wilbaker added the disk-layout Issues that impact the disk layout used by Scalar label Oct 2, 2019
@derrickstolee derrickstolee mentioned this issue Oct 3, 2019
Merged
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
derrickstolee added a commit that referenced this issue Oct 4, 2019
@derrickstolee
Merge pull request #122: Use GVFS Helper transport instead of read ob…
a8b0b08 
…ject hook

See microsoft/git#191 for the Git code regarding the GVFS transport layer. This can work in tandem with the read-object hook, but it _should_ make the read-object hook irrelevant.

* Delete all references to the read-object hook in the product code. This unblocks #4 and the [Mount Removal] tasks #15,  #132, #133, #135, #136, and possible others.

* Delete the Sparse Verb in favor of `git sparse-checkout set`.

* Delete the `BlobPrefetcher` and all references to `--files` or `--folders` prefetching.

Resolves #6, #7, #36.
@wilbaker wilbaker self-assigned this Oct 10, 2019
@wilbaker wilbaker mentioned this issue Oct 29, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilbaker wilbaker

Labels
disk-layout Issues that impact the disk layout used by Scalar engineering
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Register repo when cloning and remove mount and unmount wilbaker/gsd
3 participants
@derrickstolee @jrbriggs @wilbaker