Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mount Removal] Remove shared cache mapping file #135

Closed
wilbaker opened this issue Oct 1, 2019 · 1 comment · Fixed by #158
Closed

[Mount Removal] Remove shared cache mapping file #135

wilbaker opened this issue Oct 1, 2019 · 1 comment · Fixed by #158
Assignees
@wilbaker
Labels
disk-layout Issues that impact the disk layout used by Scalar
Milestone
MVP

Comments

@wilbaker
Copy link
Member

wilbaker commented Oct 1, 2019 •
edited
Loading

This is required to ensure that multiple clones of the same repo will use the same cache folder, even when the cache folders are deleted between the clones getting created:

  1. Clone repo
  2. Delete shared cache
  3. Clone a second copy of the repo

Both copies should use the same shared cache location.

Rather than using a mapping file, the following approach can be used:

  • Append vsts/info to the clone URL and check if there is a response.
  • If there is a response: Use the repo ID in the response
  • If there is not a response: Use a stable hash to compute a folder name from the URL

Additionally, drop a text file inside the repo specific cache directory that includes the name/URL of the repo. That file should get picked up by the diagnose verb.
@wilbaker wilbaker self-assigned this Oct 1, 2019
@wilbaker wilbaker added the disk-layout Issues that impact the disk layout used by Scalar label Oct 2, 2019
@wilbaker wilbaker changed the title [Mount Removal] Move shared cache mapping file to a global location [Mount Removal] Remove shared cache mapping file Oct 2, 2019
@derrickstolee derrickstolee mentioned this issue Oct 3, 2019
Merged
@wilbaker wilbaker mentioned this issue Oct 3, 2019
Merged
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
derrickstolee added a commit that referenced this issue Oct 4, 2019
@derrickstolee
Merge pull request #122: Use GVFS Helper transport instead of read ob…
a8b0b08 
…ject hook

See microsoft/git#191 for the Git code regarding the GVFS transport layer. This can work in tandem with the read-object hook, but it _should_ make the read-object hook irrelevant.

* Delete all references to the read-object hook in the product code. This unblocks #4 and the [Mount Removal] tasks #15,  #132, #133, #135, #136, and possible others.

* Delete the Sparse Verb in favor of `git sparse-checkout set`.

* Delete the `BlobPrefetcher` and all references to `--files` or `--folders` prefetching.

Resolves #6, #7, #36.
@wilbaker
Copy link
Member Author

wilbaker commented Oct 4, 2019

Additionally, drop a text file inside the repo specific cache directory that includes the name/URL of the repo. That file should get picked up by the diagnose verb.

Splitting this work out into a separate work item as it is not a breaking disk layout change

This was referenced Oct 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilbaker wilbaker

Labels
disk-layout Issues that impact the disk layout used by Scalar
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

[Mount Removal] Remove mapping.dat from .scalarCache wilbaker/gsd
2 participants
@derrickstolee @wilbaker