Fix ctrl+enter and alt+enter by removing the redundant command. #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -86,7 +86,7 @@ | |||
| { | |||
| "command": "jupyter.runcurrentcell", | |||
| "key": "ctrl+enter", | |||
| "when": "editorTextFocus && !editorHasSelection && jupyter.hascodecells && !notebookEditorFocused" | |||
| "when": "editorTextFocus && !editorHasSelection && jupyter.hascodecells && !notebookEditorFocused && !jupyter.hasnativecells" | |||
There was a problem hiding this comment.
You have has here, it's actually havenativecells. Annoying I know, wish we could actually have safe typing on these :/
Codecov Report
@@ Coverage Diff @@
## main #4769 +/- ##
======================================
Coverage 76% 76%
======================================
Files 411 411
Lines 26958 26963 +5
Branches 3907 3908 +1
======================================
+ Hits 20639 20756 +117
+ Misses 4729 4601 -128
- Partials 1590 1606 +16
|
DavidKutu
approved these changes
Feb 12, 2021
rchiodo
added a commit
that referenced
this pull request
Feb 12, 2021
* Fix ctrl+enter and alt+enter by removing the redundant command. * Code review feedback
rchiodo
added a commit
that referenced
this pull request
Feb 12, 2021
* Fix ctrl+enter and alt+enter by removing the redundant command. (#4769) * Fix ctrl+enter and alt+enter by removing the redundant command. * Code review feedback * Update changelog
rchiodo
added a commit
that referenced
this pull request
Feb 18, 2021
* Fix ctrl+enter and alt+enter by removing the redundant command. (#4769) * Fix ctrl+enter and alt+enter by removing the redundant command. * Code review feedback * Update changelog
rchiodo
added a commit
that referenced
this pull request
Feb 18, 2021
* PORT Variable view icon to release branch (#4748) * update changelog (#4752) * Cherry pick change for icon overflow (#4753) * Change number of icons in notebook toolbar (#4747) * Fix icons * Have trust command show up and nothing else if untrusted * Add trust check to all commands * Update based on discussion * Update change log * PORT - variable context (#4770) * Add new editor context for just if native notebook is active (#4762) * update news Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> * Port control enter fix to release (#4774) * Fix ctrl+enter and alt+enter by removing the redundant command. (#4769) * Fix ctrl+enter and alt+enter by removing the redundant command. * Code review feedback * Update changelog * port .NET fix to release (#4776) * Fix .NET interactive to always use native (#4772) * Fix .NET interactive * Fix tests and linter * Update changelog * Port kernel finder change to release (#4799) * Fix duplicate kernel generation (#4790) * Fix duplicate kernel generation * Fix functional tests * Update changelog * Actually use stable * PORT - Port document dispose fix to release. (#4798) * Only clean up editors on close not on Panel dispose (#4787) * update changelog Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> * Port surveys (#4804) * Refactor surveys and add a new one (#4794) * Refactor surveys and add a new one * add news and lint * lint * lint * PR comments * update changelog * Fix IJupyterExtensionBanner service identifier (#4825) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> * PORT - Fix for top level save and undo commands (#4851) * Update cache ignore * Actually ignore .so files * Update release plan * Put back package.json changes * Delete news entries Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4713