Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #4825

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Fix tests #4825

merged 3 commits into from
Feb 16, 2021

Conversation

joyceerhl
Copy link
Contributor

For #4824

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@joyceerhl joyceerhl requested a review from a team as a code owner February 16, 2021 17:42
@codecov-io
Copy link

Codecov Report

Merging #4825 (454f584) into main (88d1d0f) will decrease coverage by 6%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            main   #4825     +/-   ##
=======================================
- Coverage     74%     68%     -7%     
=======================================
  Files        410     410             
  Lines      26939   26940      +1     
  Branches    3902    3902             
=======================================
- Hits       20076   18328   -1748     
- Misses      5302    7193   +1891     
+ Partials    1561    1419    -142     
Impacted Files Coverage Δ
src/client/activation/serviceRegistry.ts 100% <100%> (ø)
.../datascience/jupyter/kernels/cellExecutionQueue.ts 10% <0%> (-83%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 8% <0%> (-65%) ⬇️
...datascience/telemetry/interpreterPackageTracker.ts 19% <0%> (-60%) ⬇️
...nt/datascience/notebook/helpers/notebookUpdater.ts 36% <0%> (-58%) ⬇️
.../client/datascience/notebook/kernelWithMetadata.ts 13% <0%> (-58%) ⬇️
src/client/common/application/activeResource.ts 27% <0%> (-55%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 7% <0%> (-55%) ⬇️
...ce/notebookStorage/notebookModelSynchronization.ts 33% <0%> (-54%) ⬇️
...ient/datascience/jupyter/kernels/kernelProvider.ts 43% <0%> (-52%) ⬇️
... and 121 more

@joyceerhl joyceerhl merged commit cfc328a into main Feb 16, 2021
@joyceerhl joyceerhl deleted the joyceerhl/fix-test branch February 16, 2021 20:02
DavidKutu pushed a commit that referenced this pull request Feb 16, 2021
* Refactor surveys and add a new one (#4794)

* Refactor surveys and add a new one

* add news and lint

* lint

* lint

* PR comments

* update changelog

* Fix IJupyterExtensionBanner service identifier (#4825)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
rchiodo pushed a commit that referenced this pull request Feb 18, 2021
* Refactor surveys and add a new one (#4794)

* Refactor surveys and add a new one

* add news and lint

* lint

* lint

* PR comments

* update changelog

* Fix IJupyterExtensionBanner service identifier (#4825)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
rchiodo added a commit that referenced this pull request Feb 18, 2021
* PORT Variable view icon to release branch (#4748)

* update changelog (#4752)

* Cherry pick change for icon overflow (#4753)

* Change number of icons in notebook toolbar (#4747)

* Fix icons

* Have trust command show up and nothing else if untrusted

* Add trust check to all commands

* Update based on discussion

* Update change log

* PORT - variable context (#4770)

* Add new editor context for just if native notebook is active (#4762)

* update news

Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com>

* Port control enter fix to release (#4774)

* Fix ctrl+enter and alt+enter by removing the redundant command. (#4769)

* Fix ctrl+enter and alt+enter by removing the redundant command.

* Code review feedback

* Update changelog

* port .NET fix to release (#4776)

* Fix .NET interactive to always use native (#4772)

* Fix .NET interactive

* Fix tests and linter

* Update changelog

* Port kernel finder change to release (#4799)

* Fix duplicate kernel generation (#4790)

* Fix duplicate kernel generation

* Fix functional tests

* Update changelog

* Actually use stable

* PORT - Port document dispose fix to release. (#4798)

* Only clean up editors on close not on Panel dispose (#4787)

* update changelog

Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com>

* Port surveys (#4804)

* Refactor surveys and add a new one (#4794)

* Refactor surveys and add a new one

* add news and lint

* lint

* lint

* PR comments

* update changelog

* Fix IJupyterExtensionBanner service identifier (#4825)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* PORT - Fix for top level save and undo commands (#4851)

* Update cache ignore

* Actually ignore .so files

* Update release plan

* Put back package.json changes

* Delete news entries

Co-authored-by: Ian Huff <ianhu@microsoft.com>
Co-authored-by: David Kutugata <dakutuga@microsoft.com>
Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com>
Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants