Port surveys #4804
Merged
Port surveys #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2021 18:22
* Refactor surveys and add a new one * add news and lint * lint * lint * PR comments
Codecov Report
@@ Coverage Diff @@
## release-2021.02 #4804 +/- ##
================================================
- Coverage 73% 72% -1%
================================================
Files 411 410 -1
Lines 26960 26942 -18
Branches 3907 3903 -4
================================================
- Hits 19882 19660 -222
- Misses 5489 5703 +214
+ Partials 1589 1579 -10
|
DonJayamanne
requested changes
Feb 16, 2021
| 1. Minimize number of icons on the notebook toolbar (put the rest in overflow). | ||
| ([#4730](https://github.com/Microsoft/vscode-jupyter/issues/4730)) | ||
| 1. Add survey for the new Notebooks experience experiment. | ||
| ([#4726](https://github.com/microsoft/vscode-jupyter/issues/4726)) |
There was a problem hiding this comment.
I thought we already had a survey for native notebooks & #4726 was just an update to the uri.
Or am i mistaken?
There was a problem hiding this comment.
Its a different survey, the old one is for native notebooks in insiders, this one is for the experiment. We want to have both.
|
Smoke tests don't seem to be passing. I think you need to fix this part too: Meaning port Joyce's fix once it goes through as well. |
DonJayamanne
approved these changes
Feb 16, 2021
rchiodo
approved these changes
Feb 16, 2021
joyceerhl
approved these changes
Feb 16, 2021
rchiodo
pushed a commit
that referenced
this pull request
Feb 18, 2021
rchiodo
added a commit
that referenced
this pull request
Feb 18, 2021
* PORT Variable view icon to release branch (#4748) * update changelog (#4752) * Cherry pick change for icon overflow (#4753) * Change number of icons in notebook toolbar (#4747) * Fix icons * Have trust command show up and nothing else if untrusted * Add trust check to all commands * Update based on discussion * Update change log * PORT - variable context (#4770) * Add new editor context for just if native notebook is active (#4762) * update news Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> * Port control enter fix to release (#4774) * Fix ctrl+enter and alt+enter by removing the redundant command. (#4769) * Fix ctrl+enter and alt+enter by removing the redundant command. * Code review feedback * Update changelog * port .NET fix to release (#4776) * Fix .NET interactive to always use native (#4772) * Fix .NET interactive * Fix tests and linter * Update changelog * Port kernel finder change to release (#4799) * Fix duplicate kernel generation (#4790) * Fix duplicate kernel generation * Fix functional tests * Update changelog * Actually use stable * PORT - Port document dispose fix to release. (#4798) * Only clean up editors on close not on Panel dispose (#4787) * update changelog Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> * Port surveys (#4804) * Refactor surveys and add a new one (#4794) * Refactor surveys and add a new one * add news and lint * lint * lint * PR comments * update changelog * Fix IJupyterExtensionBanner service identifier (#4825) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> * PORT - Fix for top level save and undo commands (#4851) * Update cache ignore * Actually ignore .so files * Update release plan * Put back package.json changes * Delete news entries Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: Ian Huff <ianhuff@LICHYOGAIOT.northamerica.corp.microsoft.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4726
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).