Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-skip some Jedi-related tests on Windows. #10399

Closed
ericsnowcurrently opened this issue Mar 2, 2020 · 1 comment
Closed

Un-skip some Jedi-related tests on Windows. #10399

ericsnowcurrently opened this issue Mar 2, 2020 · 1 comment
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone
September 2021

Comments

@ericsnowcurrently
Copy link
Member

(See #10357)

We updated CI to test against 3.8 in #10276. That revealed that some of our Jedi-related tests fail on 3.8, but only on Windows. We skipped those tests and need to fix them so they pass.
@ericsnowcurrently ericsnowcurrently added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority labels Mar 2, 2020
@ericsnowcurrently ericsnowcurrently mentioned this issue Mar 3, 2020
Merged
ericsnowcurrently added a commit that referenced this issue Mar 3, 2020
@ericsnowcurrently
Temporarily disable some tests. (#10400)
63befc6 
(for #10357)

We updated CI to test against 3.8 in #10276. Doing so revealed that some of our Jedi-related tests fail on 3.8, but only on Windows. We're temporarily skipping those tests. The will be fixed in #10399.
@luabud luabud added area-internal Label for non-user facing issues and removed feature-* labels May 13, 2020
@luabud luabud removed the important Issue identified as high-priority label Jun 10, 2020
@kimadeline
Copy link

Closing as stale since these tests were removed with #17225.

@kimadeline kimadeline added this to the September 2021 milestone Sep 20, 2021
@kimadeline kimadeline added the verified Verification succeeded label Sep 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
3 participants
@ericsnowcurrently @luabud @kimadeline