Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable some tests. #10400

Conversation

ericsnowcurrently
Copy link
Member

(for #10357)

We updated CI to test against 3.8 in #10276. That revealed that some of our Jedi-related tests fail on 3.8, but only on Windows. We're temporarily skipping those tests. The will be fixed in #10399.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Mar 3, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #10400 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10400      +/-   ##
==========================================
- Coverage   60.88%   60.86%   -0.02%     
==========================================
  Files         570      570              
  Lines       30758    30758              
  Branches     4379     4379              
==========================================
- Hits        18727    18721       -6     
- Misses      11080    11084       +4     
- Partials      951      953       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762d236...2e3c31f. Read the comment docs.

@ericsnowcurrently ericsnowcurrently merged commit 63befc6 into microsoft:master Mar 3, 2020
@ericsnowcurrently ericsnowcurrently deleted the ci-disable-test-jedi-38 branch March 3, 2020 17:08
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants